recompile uses wrong buffer.. hint

recompile uses wrong buffer.. hint

[Stephan Stahl]

Hi.

I tried to find a solution to this problem and at least found what was
causing this strange behaviour.

The function `compilation-buffer-name' tries to get a name for the
compilation buffer. There is a test:
	((and (eq major-mode 'compilation-mode)
	      (equal mode-name (nth 2 compilation-arguments)))
	 (buffer-name))
that equal will (always?) return nil because the structure of
compilation-arguments has changed in the recent compile.el rewrite.
Because of this the function will always return a default name. Maybe its
sufficient to remove that equal but i'm not sure..

-- 
Stephan Stahl

Re: recompile uses wrong buffer.. hint

[Juri Linkov]

"Stephan Stahl" <stahl@eos.franken.de> writes:
> I tried to find a solution to this problem and at least found what was
> causing this strange behaviour.
>
> The function `compilation-buffer-name' tries to get a name for the
> compilation buffer. There is a test:
> 	((and (eq major-mode 'compilation-mode)
> 	      (equal mode-name (nth 2 compilation-arguments)))
> 	 (buffer-name))
> that equal will (always?) return nil because the structure of
> compilation-arguments has changed in the recent compile.el rewrite.
> Because of this the function will always return a default name. Maybe its
> sufficient to remove that equal but i'm not sure..

Removing `equal' and thus leaving only `(eq major-mode 'compilation-mode)'
doesn't work for grep mode.  I think the right condition should be:

	((eq major-mode (nth 1 compilation-arguments))
	 (buffer-name))

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: recompile uses wrong buffer.. hint

[Juri Linkov]

> 	((eq major-mode (nth 1 compilation-arguments))
> 	 (buffer-name))

I think exactly the same condition should be used in `recompile'
to get the right directory when invoked in the compilation buffer:

Index: lisp/progmodes/compile.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v
retrieving revision 1.320
diff -u -r1.320 compile.el
--- lisp/progmodes/compile.el	28 May 2004 21:11:41 -0000	1.320
+++ lisp/progmodes/compile.el	7 Jun 2004 12:20:15 -0000
@@ -787,7 +787,10 @@
 original use.  Otherwise, recompile using `compile-command'."
   (interactive)
   (save-some-buffers (not compilation-ask-about-save) nil)
-  (let ((default-directory (or compilation-directory default-directory)))
+  (let ((default-directory
+          (or (and (not (eq major-mode (nth 1 compilation-arguments)))
+                   compilation-directory)
+              default-directory)))
     (apply 'compilation-start (or compilation-arguments
 				  `(,(eval compile-command))))))
 
@@ -814,8 +817,7 @@
 	 (funcall name-function mode-name))
 	(compilation-buffer-name-function
 	 (funcall compilation-buffer-name-function mode-name))
-	((and (eq major-mode 'compilation-mode)
-	      (equal mode-name (nth 2 compilation-arguments)))
+	((eq major-mode (nth 1 compilation-arguments))
 	 (buffer-name))
 	(t
 	 (concat "*" (downcase mode-name) "*"))))

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: recompile uses wrong buffer.. hint

[Richard Stallman]

    > 	((eq major-mode (nth 1 compilation-arguments))
    > 	 (buffer-name))

    I think exactly the same condition should be used in `recompile'
    to get the right directory when invoked in the compilation buffer:

If nobody finds a flaw in this patch in a few days, would you
please install it?