From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Jesper Harder <harder@phys.au.dk>
Newsgroups: gmane.emacs.devel
Subject: Re: Suspicious code in gnus-read-descriptions-file
Date: Wed, 23 Mar 2005 00:17:29 +0100
Organization: http://purl.org/harder/
Message-ID: <87eke71cnj.fsf@Jesper-Harders-Computer.local>
References: <jwvzmwvo6sb.fsf-monnier+emacs@gnu.org>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1111534624 1481 80.91.229.2 (22 Mar 2005 23:37:04 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Tue, 22 Mar 2005 23:37:04 +0000 (UTC)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 23 00:37:03 2005
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1DDsva-0000bZ-6f
	for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2005 00:36:50 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1DDtCx-0002R8-Nm
	for ged-emacs-devel@m.gmane.org; Tue, 22 Mar 2005 18:54:47 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DDtBy-0001s3-76
	for emacs-devel@gnu.org; Tue, 22 Mar 2005 18:53:46 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DDtBt-0001p5-6S
	for emacs-devel@gnu.org; Tue, 22 Mar 2005 18:53:42 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DDtBr-0001mx-6x
	for emacs-devel@gnu.org; Tue, 22 Mar 2005 18:53:39 -0500
Original-Received: from [212.247.154.193] (helo=swip.net)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1DDsq2-0002ju-53
	for emacs-devel@gnu.org; Tue, 22 Mar 2005 18:31:06 -0500
X-T2-Posting-ID: 6v7UXmte3bqfgw4oLiS+UA==
Original-Received: from [83.72.212.87] (HELO Jesper-Harders-Computer.local)
	by mailfe07.swip.net (CommuniGate Pro SMTP 4.2.9)
	with ESMTP id 128953895 for emacs-devel@gnu.org;
	Wed, 23 Mar 2005 00:30:58 +0100
Original-To: emacs-devel@gnu.org
Original-Lines: 18
User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (darwin)
X-Face: ^RrvqCr7c,P$zTR:QED"@h9+BTm-"fjZJJ-3=OU7.)i/K]<.J88}s>'Z_$r;
	<N5ksn~%wJ@2pjF}="tV; FBsdpFarSWA<oYkZsViGf:F^SD-KXhvFxh;
	~]?)SWm~+u}; 0=x}<vOm&5J+?]yB2d]q4x8\0g7SX
Mail-Copies-To: never
Cancel-Lock: sha1:WGedLUwb+uzdVKflh2qS4warE9Y=
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
X-MailScanner-To: ged-emacs-devel@m.gmane.org
Xref: news.gmane.org gmane.emacs.devel:35010
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35010

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>  (defun gnus-parse-active ()
>    "Parse active info in the nntp server buffer."
> -  (save-excursion
> -    (set-buffer nntp-server-buffer)
> +  (with-current-buffer nntp-server-buffer
>      (goto-char (point-min))

Are you sure that not saving (and restoring) point in
nntp-server-buffer doesn't make a difference?

I've made the same change a lot of places in Gnus ... and if the code
in the `with-current-buffer'-form doesn't change point, it's a
no-brainer, of course.  

But if point /is/ changed, I've often found it pretty hard to be
absolutely sure if saving point is actually intended and required.