all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* cvs-mode-diff on marked files
@ 2005-12-08  7:47 Juri Linkov
  2005-12-08 16:51 ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2005-12-08  7:47 UTC (permalink / raw)


I wonder what are the reasons for cvs-mode-diff to ignore selected
files?  It is very convenient to mark all relevant files in the *cvs*
buffer and type `=' to generate a composite patch.  But currently
`cvs-invert-ignore-marks' contains "diff" by default, thus preventing
`=' to operate on all selected files.  It operates only on the current
file at point.  Even the documentation string of `cvs-mode-diff' says
"Diff the selected files against the repository" where "selected files"
is in the plural form.

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-08  7:47 cvs-mode-diff on marked files Juri Linkov
@ 2005-12-08 16:51 ` Stefan Monnier
  2005-12-09  9:59   ` Juri Linkov
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2005-12-08 16:51 UTC (permalink / raw)
  Cc: emacs-devel

> I wonder what are the reasons for cvs-mode-diff to ignore selected
> files?  It is very convenient to mark all relevant files in the *cvs*
> buffer and type `=' to generate a composite patch.  But currently
> `cvs-invert-ignore-marks' contains "diff" by default, thus preventing
> `=' to operate on all selected files.  It operates only on the current
> file at point.  Even the documentation string of `cvs-mode-diff' says
> "Diff the selected files against the repository" where "selected files"
> is in the plural form.

With the prefix T you can get what you want: T =
As for why, it's mostly historical (that's how it was originally in PCL-CVS
when I took over maintenance and it may have been originally due to
limitations of early CVS).  I actually like it because I often select
files to commit and then do diff one file at a time (either to fill the
ChangeLog or to decide whether to add the file to set of selected files for
commit).


        Stefan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-08 16:51 ` Stefan Monnier
@ 2005-12-09  9:59   ` Juri Linkov
  2005-12-09 14:12     ` Andreas Schwab
  0 siblings, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2005-12-09  9:59 UTC (permalink / raw)
  Cc: emacs-devel

> With the prefix T you can get what you want: T =
> As for why, it's mostly historical (that's how it was originally in PCL-CVS
> when I took over maintenance and it may have been originally due to
> limitations of early CVS).  I actually like it because I often select
> files to commit and then do diff one file at a time (either to fill the
> ChangeLog or to decide whether to add the file to set of selected files for
> commit).

Thanks, now I see.  The same problem exists in Dired where `!' always
operates on marked files.  I use the special command that operates on
the file at point.

(defun my-dired-do-shell-command-on-current-file (&optional arg)
  "Run a shell command on the current file instead of marked files."
  (interactive)
  (let ((dired-marker-char ?M))         ; ?M is unused marker char
    (call-interactively 'dired-do-shell-command)))
(define-key dired-mode-map "%!" 'my-dired-do-shell-command-on-current-file)
(define-key dired-mode-map [(control meta ?!)] 'my-dired-do-shell-command-on-current-file)

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-09  9:59   ` Juri Linkov
@ 2005-12-09 14:12     ` Andreas Schwab
  2005-12-09 23:55       ` Juri Linkov
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2005-12-09 14:12 UTC (permalink / raw)
  Cc: Stefan Monnier, emacs-devel

Juri Linkov <juri@jurta.org> writes:

> Thanks, now I see.  The same problem exists in Dired where `!' always
> operates on marked files.

Unless you pass a prefix argument.

> I use the special command that operates on the file at point.

M-1 !

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-09 14:12     ` Andreas Schwab
@ 2005-12-09 23:55       ` Juri Linkov
  2005-12-10 13:57         ` Stefan Monnier
  0 siblings, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2005-12-09 23:55 UTC (permalink / raw)
  Cc: monnier, emacs-devel

>> Thanks, now I see.  The same problem exists in Dired where `!' always
>> operates on marked files.
>
> Unless you pass a prefix argument.

Thanks, I missed this too.  It would be good to think after the
release about making PCL-CVS more similar to Dired.  Ideally, PCV-CVS
should be a sub-mode of Dired mode with CVS status information
displayed instead of permission bits, group and owner names, and with
some its keys bound to CVS commands.

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-09 23:55       ` Juri Linkov
@ 2005-12-10 13:57         ` Stefan Monnier
  2005-12-12  7:45           ` Juri Linkov
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2005-12-10 13:57 UTC (permalink / raw)
  Cc: Andreas Schwab, emacs-devel

> Thanks, I missed this too.  It would be good to think after the
> release about making PCL-CVS more similar to Dired.  Ideally, PCV-CVS
> should be a sub-mode of Dired mode with CVS status information
> displayed instead of permission bits, group and owner names, and with
> some its keys bound to CVS commands.

I won't comment on this idea until I see patches, but I'm not
too enthusiastic to waste screen real estate on info such as group
and owner name that I use, like, once every other year, maybe?

Maybe you'd be better served with VC-dired ?


        Stefan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-10 13:57         ` Stefan Monnier
@ 2005-12-12  7:45           ` Juri Linkov
  2005-12-14  9:18             ` Lars Hansen
  0 siblings, 1 reply; 8+ messages in thread
From: Juri Linkov @ 2005-12-12  7:45 UTC (permalink / raw)
  Cc: schwab, emacs-devel

> I won't comment on this idea until I see patches, but I'm not
> too enthusiastic to waste screen real estate on info such as group
> and owner name that I use, like, once every other year, maybe?
>
> Maybe you'd be better served with VC-dired ?

I tried out VC-dired, but it doesn't seem to be so convenient and
feature-rich as PCL-CVS.  OTOH, its dired-like appearance is quite good.

BTW, after trying VC-dired, it saved vc-dired-mode buffers to the
desktop file which failed during restoring.  Does this bug mean that
nobody uses VC-dired?  OK, more precisely, this means nobody uses
VC-dired with desktop.el :-)  I could install the following fix if
there are no objections.

Index: lisp/desktop.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/desktop.el,v
retrieving revision 1.95
diff -c -r1.95 desktop.el
*** lisp/desktop.el	21 Oct 2005 08:48:53 -0000	1.95
--- lisp/desktop.el	12 Dec 2005 07:44:44 -0000
***************
*** 411,417 ****
  
  (defcustom desktop-minor-mode-table
    '((auto-fill-function auto-fill-mode)
!     (vc-mode nil))
    "Table mapping minor mode variables to minor mode functions.
  Each entry has the form (NAME RESTORE-FUNCTION).
  NAME is the name of the buffer-local variable indicating that the minor
--- 411,418 ----
  
  (defcustom desktop-minor-mode-table
    '((auto-fill-function auto-fill-mode)
!     (vc-mode nil)
!     (vc-dired-mode nil))
    "Table mapping minor mode variables to minor mode functions.
  Each entry has the form (NAME RESTORE-FUNCTION).
  NAME is the name of the buffer-local variable indicating that the minor

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: cvs-mode-diff on marked files
  2005-12-12  7:45           ` Juri Linkov
@ 2005-12-14  9:18             ` Lars Hansen
  0 siblings, 0 replies; 8+ messages in thread
From: Lars Hansen @ 2005-12-14  9:18 UTC (permalink / raw)
  Cc: schwab, Stefan Monnier, emacs-devel

Juri Linkov wrote:

>BTW, after trying VC-dired, it saved vc-dired-mode buffers to the
>desktop file which failed during restoring.  Does this bug mean that
>nobody uses VC-dired?  OK, more precisely, this means nobody uses
>VC-dired with desktop.el :-)  I could install the following fix if
>there are no objections.
>  
>
Please do.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2005-12-14  9:18 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-08  7:47 cvs-mode-diff on marked files Juri Linkov
2005-12-08 16:51 ` Stefan Monnier
2005-12-09  9:59   ` Juri Linkov
2005-12-09 14:12     ` Andreas Schwab
2005-12-09 23:55       ` Juri Linkov
2005-12-10 13:57         ` Stefan Monnier
2005-12-12  7:45           ` Juri Linkov
2005-12-14  9:18             ` Lars Hansen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.