From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [rudalics@gmx.at: check_min_window_sizes] Date: Sat, 18 Feb 2006 10:28:03 -0500 Message-ID: <87ek208z5o.fsf@stupidchicken.com> References: <87u0axpbba.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140294876 20342 80.91.229.2 (18 Feb 2006 20:34:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2006 20:34:36 +0000 (UTC) Cc: martin rudalics , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 18 21:34:29 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FAYme-0001Hu-Kf for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2006 21:34:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAYme-00076d-2D for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2006 15:34:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FAUEZ-0004Hb-Ex for emacs-devel@gnu.org; Sat, 18 Feb 2006 10:42:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FAU8w-0002SZ-4E for emacs-devel@gnu.org; Sat, 18 Feb 2006 10:37:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FAU0E-0007MP-IJ for emacs-devel@gnu.org; Sat, 18 Feb 2006 10:28:07 -0500 Original-Received: from [18.95.6.7] (helo=outgoing.mit.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FAU5l-0002oe-Sb; Sat, 18 Feb 2006 10:33:49 -0500 Original-Received: by outgoing.mit.edu (Postfix, from userid 1000) id 91EDD1E423B; Sat, 18 Feb 2006 10:28:03 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: <87u0axpbba.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 17 Feb 2006 22:58:49 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50709 Archived-At: >> (progn >> (split-window-horizontally) >> (let ((window-min-width 1)) >> (shrink-window (1- (window-width)) t))) >> >> removes scrollbars from both emanating windows and makes the left window >> inaccessible. For some strange reason `check_min_window_sizes' seems to >> fail here. > > This patch removes the bug. On second thought, the patch I posted was the wrong fix. I believe this one is correct (basically, size_window was checking for a safe_min_size that included the width of window fringes and scrollbars, but window_min_size_1 did not check for it). *** emacs/src/window.c.~1.534.~ 2006-02-18 10:15:46.000000000 -0500 --- emacs/src/window.c 2006-02-18 10:23:42.000000000 -0500 *************** *** 2568,2574 **** else { if (width_p) ! size = window_min_width; else { if (MINI_WINDOW_P (w) --- 2568,2577 ---- else { if (width_p) ! size = max (window_min_width, ! (MIN_SAFE_WINDOW_WIDTH ! + WINDOW_FRINGE_COLS (w) ! + WINDOW_SCROLL_BAR_COLS (w))); else { if (MINI_WINDOW_P (w)