From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael@cadilhac.name (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: Your last change to browse-url is bogus. Date: Wed, 12 Sep 2007 12:38:51 +0200 Organization: Epita/LRDE Message-ID: <87ejh42mo4.fsf@cadilhac.name> References: <87zlzs2qm1.fsf@cadilhac.name> <20070912102039.GD12104@saeurebad.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1468778077==" X-Trace: sea.gmane.org 1189593772 7547 80.91.229.12 (12 Sep 2007 10:42:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 12 Sep 2007 10:42:52 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 12 12:42:49 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IVPgG-0003m2-6u for ged-emacs-devel@m.gmane.org; Wed, 12 Sep 2007 12:42:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IVPgF-0005Da-Qt for ged-emacs-devel@m.gmane.org; Wed, 12 Sep 2007 06:42:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IVPgB-0005D9-OY for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:42:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IVPgA-0005Cw-8I for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:42:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IVPgA-0005Ct-4p for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:42:42 -0400 Original-Received: from smtp3-g19.free.fr ([212.27.42.29]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IVPg9-0002bI-KW for emacs-devel@gnu.org; Wed, 12 Sep 2007 06:42:41 -0400 Original-Received: from smtp3-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp3-g19.free.fr (Postfix) with ESMTP id 1FEA177D7 for ; Wed, 12 Sep 2007 12:42:41 +0200 (CEST) Original-Received: from localhost (ivr94-6-82-230-255-91.fbx.proxad.net [82.230.255.91]) by smtp3-g19.free.fr (Postfix) with ESMTP id D085E5A153 for ; Wed, 12 Sep 2007 12:42:40 +0200 (CEST) X-Website: http://michael.cadilhac.name Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU/JREXDATg1LV8UCao i1fQpmoP3Nd6AAACa0lEQVQ4jWWUQW7jMAxFqZEPICJzAjXeM6W8dyNqX9ji/a8yn04xnWIEJLD9 LJH85DcJFyJV3erqPty8ExHfBikXSdn0WVezC0hOAQiA2nCsAHOqEnPe4k+puU8zw/t+xquqjRKA 4lHsmQBT8C5pDtBwfwH8VdcHI5+FHtjRxrQRwZsf3hNjZRKAPEzHEdH9mFNSYb5dQK3r8KM6ftNy KikAirDZFWdVkDqbxjGFbAcwbQCxxc8mPRHUGOcCIMgMACV23RfJTch3gC6ofT3qCdG0NyUUPfYF yQrKCIAnuYsgX2qPzW2i9sNrfSOSPPZQiygtCNlCjlpXJV38lIKshF/AZzsAMoArdCKNHfXukPuJ ImbLh+9J2gXwap0QpZ7NjZ7ekdkFcDiqPiLGcHmuvaG/AHgy62s52Lae1ABoA7D6d2kDoAvgbnyD ZutEd6lTHOXfYPHVJDH1K8a1+oyrjoZpAGn1x5pfwPr2E9yjxSpk50/gEyKgD/+BD/KzN3tQ13b8 Cx5loF0AgnZf5IUny9hRHQOYBllHDM+6s3oviZBu77mFjDm621Np3hkjR90wE1BkTYvhdDgDgCmR xWChFfcYAOqMm5NZkVWMur8AL5+oeMQOob2FmY76FiM+PrDDZypwGdqokSlAaQOmGH6mW8KpsOwl 0YOLedjSITr6scNRF8D4PesH33QmLrx8AzjpV/3kkg025w2gfAFYKCLluJAc4Ap+h18oo4S8wzaY klDsBUTiY8EZFkg5Iass75FubC9wd8qa0u9+gRxAsAKEaRAo6iB+vwCMGmdBjvgidQGA1ntMX4CS ZYGV/wADyL80LIX/UAAAAABJRU5ErkJggg== In-Reply-To: <20070912102039.GD12104@saeurebad.de> (Johannes Weiner's message of "Wed, 12 Sep 2007 12:20:39 +0200") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78658 Archived-At: --===============1468778077== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Johannes Weiner writes: > On Wed, Sep 12, 2007 at 11:13:42AM +0200, Micha=EBl Cadilhac wrote: >> use something like this: > >> --- browse-url.el 12 Sep 2007 10:49:04 +0200 1.61 >> +++ browse-url.el 12 Sep 2007 11:09:27 +0200=09 > [...] >> - (setq file (browse-url-encode-url file)) >> + (setq file (browse-url-encode-url file "[*\"()',=3D;? ]" 'encode-perc= ent)) > [...] >> - (setq url (browse-url-encode-url url)) >> + (setq url (browse-url-encode-url url "[,)$]")) > [...] >> - (setq url (browse-url-encode-url url)) >> + (setq url (browse-url-encode-url url "[,)$]")) > [...] >> - (setq url (browse-url-encode-url url)) >> + (setq url (browse-url-encode-url url "[,)$]")) > [...] >> - (setq url (browse-url-encode-url url)) >> + (setq url (browse-url-encode-url url "[,)$]")) > [...] >> - (setq url (browse-url-encode-url url)) >> + (setq url (browse-url-encode-url url "[,)$]")) > [...] >> - (setq url (browse-url-encode-url url)) >> + (setq url (browse-url-encode-url url "[,)$]")) > > These use mostly the same argument. Can't we generalize this? Would it = hurt > the callsites if they all would use "[*\"()',=3D;? ]"? Yes, it will. A ``confusing char'' is just something Firefox or others can consider as a URL separator or as a variable or something when the website is passed as an argument to the executable, AFAIU. `?=3D*' for example are not usually ``confusing''. The only place those chars are to be converted is when we browse for a file (thus when `?=3D' don't have their special meanings). In the other cases, removing those chars destroys the meaning of the URL. =2D-=20 | Micha=EBl `Micha' Cadilhac | And please suggest to him that = | | http://michael.cadilhac.name | he not refer to Microsoft Windows = | | JID/MSN: | as "win". = | `---- michael.cadilhac@gmail.com | -- RMS - = --' --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.2 (GNU/Linux) iD8DBQFG58G8UJhDmOfFA3URAp0hAJ45DpFdM1BG+FLN6XwKDn+0fw/YAQCdGlXL GQ7wONkcJ6d6BYLuG2ywb50= =+Rb3 -----END PGP SIGNATURE----- --=-=-=-- --===============1468778077== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1468778077==--