Re: bookmark.el and lisp/gnus/gnus-bookmark.el

[Tassilo Horn <tassilo@member.fsf.org>]

Bastien <bzg@altern.org> writes:

Hi Bastien,

>>> He added the buffer-local variable `bookmark-make-cell-function',
>>> which lets you define a handler for a mode: when setting a bookmark,
>>> a handler is added to the record and jumping to the bookmark will
>>> use this handler instead of `bookmark-jump' (see
>>> `bookmark-jump-internal'.)
>>
>>> This is all good, but it only works for buffer visiting files and
>>> Info-mode.
>>
>> I don't understand why you think so.  Could you explain in more
>> details?
>
> This boils down to this: having a `bookmark-make-name-function' doing
> for the names of the bookmarks what `bookmark-make-cell-function' does
> for the records.  This would be locally set depending on the mode
> we're in.
>
> For now the the name of the bookmark is set by
> bookmark-buffer-file-name which doesn't return anything unless you are
> in a buffer visiting a file or an Info node, or dired.

Hm, looking at the code `bookmark-buffer-file-name' is only called for
buffers that don't have `bookmark-make-record-function' set locally, so
I don't see why you would need that?

Or am I late again and Karl's and Stefan's changes already do care oy
everything we need?

Bye,
Tassilo