bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

[Stephen Berman]

1. emacs -Q
2. C-h i m gnus RET
3. Click with mouse-1 (or mouse-2) on any of the links under "Other
   related manuals", i.e. Message, Emacs-MIME, Sieve, PGG, SASL: nothing
   happens.

Typing 'RET' on any of these links, in contrast, DTRT, i.e. goes to the
respective node.  Clicking mouse-1 on any of the other links also DTRT.
The following patch fixes the problem for me:

*** emacs/lisp/info.el.~1.542.~	2008-09-04 16:16:19.000000000 +0200
--- emacs/lisp/info.el	2008-09-04 16:22:24.000000000 +0200
***************
*** 3099,3105 ****
  At end of the node's text, moves to the next node, or up if none."
    (interactive "e")
    (mouse-set-point click)
!   (and (not (Info-try-follow-nearest-node))
         (save-excursion (forward-line 1) (eobp))
         (Info-next-preorder)))
  
--- 3099,3105 ----
  At end of the node's text, moves to the next node, or up if none."
    (interactive "e")
    (mouse-set-point click)
!   (and (not (Info-follow-nearest-node))
         (save-excursion (forward-line 1) (eobp))
         (Info-next-preorder)))
  



In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2008-08-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

bug#886: marked as done (23.0.60; Info-mouse-follow-nearest-node fails)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]


Your message dated Tue, 09 Sep 2008 22:30:54 -0400
with message-id <g0od2wka01.fsf@fencepost.gnu.org>
and subject line Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
has caused the Emacs bug report #886,
regarding 23.0.60; Info-mouse-follow-nearest-node fails
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
886: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=886
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3739 bytes --]

From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Thu, 04 Sep 2008 16:31:06 +0200
Message-ID: <87ej400yqd.fsf@escher.local.home>

1. emacs -Q
2. C-h i m gnus RET
3. Click with mouse-1 (or mouse-2) on any of the links under "Other
   related manuals", i.e. Message, Emacs-MIME, Sieve, PGG, SASL: nothing
   happens.

Typing 'RET' on any of these links, in contrast, DTRT, i.e. goes to the
respective node.  Clicking mouse-1 on any of the other links also DTRT.
The following patch fixes the problem for me:

*** emacs/lisp/info.el.~1.542.~	2008-09-04 16:16:19.000000000 +0200
--- emacs/lisp/info.el	2008-09-04 16:22:24.000000000 +0200
***************
*** 3099,3105 ****
  At end of the node's text, moves to the next node, or up if none."
    (interactive "e")
    (mouse-set-point click)
!   (and (not (Info-try-follow-nearest-node))
         (save-excursion (forward-line 1) (eobp))
         (Info-next-preorder)))
  
--- 3099,3105 ----
  At end of the node's text, moves to the next node, or up if none."
    (interactive "e")
    (mouse-set-point click)
!   (and (not (Info-follow-nearest-node))
         (save-excursion (forward-line 1) (eobp))
         (Info-next-preorder)))
  



In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2008-08-29 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1670 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 886-done@emacsbugs.donarmstrong.com
Subject: Re: bug#886: 23.0.60; Info-mouse-follow-nearest-node fails
Date: Tue, 09 Sep 2008 22:30:54 -0400
Message-ID: <g0od2wka01.fsf@fencepost.gnu.org>


Many thanks; applied.

2008-09-10  Stephen Berman  <stephen.berman@gmx.net>

    * info.el (Info-mouse-follow-nearest-node): Follow links
      to different manuals.  (Bug#886)

bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

[martin rudalics]

The fix seems to have the following side-effect: In my .emacs I bind

   (define-key Info-mode-map [mouse-1] 'Info-mouse-follow-nearest-node)

Now when I use mouse-1 to just "select" the Info-window I usually get

   Info-follow-nearest-node: Point neither on reference nor in menu item description

which is annoying :-(

martin

bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

[Stephen Berman]

On Mon, 15 Sep 2008 10:34:01 +0200 martin rudalics <rudalics@gmx.at> wrote:

> The fix seems to have the following side-effect: In my .emacs I bind
>
>   (define-key Info-mode-map [mouse-1] 'Info-mouse-follow-nearest-node)

> Now when I use mouse-1 to just "select" the Info-window I usually get
>
>   Info-follow-nearest-node: Point neither on reference nor in menu item description
>
> which is annoying :-(
>
> martin

Does the following patch fix it?

*** emacs/lisp/info.el.~1.544.~	2008-09-11 11:49:36.000000000 +0200
--- emacs/lisp/info.el	2008-09-15 11:22:53.000000000 +0200
***************
*** 3123,3129 ****
  	    (Info-goto-node
  	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
  	    t)))
!       (error "Point neither on reference nor in menu item description")))
  
  ;; Common subroutine.
  (defun Info-try-follow-nearest-node (&optional fork)
--- 3123,3130 ----
  	    (Info-goto-node
  	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
  	    t)))
!       (unless (eq this-command 'Info-mouse-follow-nearest-node)
! 	(error "Point neither on reference nor in menu item description"))))
  
  ;; Common subroutine.
  (defun Info-try-follow-nearest-node (&optional fork)


Steve Berman

bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

[martin rudalics]

 > Does the following patch fix it?
 >
 > *** emacs/lisp/info.el.~1.544.~	2008-09-11 11:49:36.000000000 +0200
 > --- emacs/lisp/info.el	2008-09-15 11:22:53.000000000 +0200
 > ***************
 > *** 3123,3129 ****
 >   	    (Info-goto-node
 >   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
 >   	    t)))
 > !       (error "Point neither on reference nor in menu item description")))
 >
 >   ;; Common subroutine.
 >   (defun Info-try-follow-nearest-node (&optional fork)
 > --- 3123,3130 ----
 >   	    (Info-goto-node
 >   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
 >   	    t)))
 > !       (unless (eq this-command 'Info-mouse-follow-nearest-node)
 > ! 	(error "Point neither on reference nor in menu item description"))))
 >
 >   ;; Common subroutine.
 >   (defun Info-try-follow-nearest-node (&optional fork)

Yes - the following seems simpler:

!       (eq this-command 'Info-mouse-follow-nearest-node)
! 	(error "Point neither on reference nor in menu item description")))

I'm not sure though whether we should raise an error for mouse-2 clicks.
But I also fail to understand why we should raise an error at all.

martin

bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

[Stephen Berman]

On Mon, 15 Sep 2008 14:11:38 +0200 martin rudalics <rudalics@gmx.at> wrote:

>> Does the following patch fix it?
>>
>> *** emacs/lisp/info.el.~1.544.~	2008-09-11 11:49:36.000000000 +0200
>> --- emacs/lisp/info.el	2008-09-15 11:22:53.000000000 +0200
>> ***************
>> *** 3123,3129 ****
>>   	    (Info-goto-node
>>   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
>>   	    t)))
>> !       (error "Point neither on reference nor in menu item description")))
>>
>>   ;; Common subroutine.
>>   (defun Info-try-follow-nearest-node (&optional fork)
>> --- 3123,3130 ----
>>   	    (Info-goto-node
>>   	     (Info-extract-menu-item (match-string-no-properties 1)) fork)
>>   	    t)))
>> !       (unless (eq this-command 'Info-mouse-follow-nearest-node)
>> ! 	(error "Point neither on reference nor in menu item description"))))
>>
>>   ;; Common subroutine.
>>   (defun Info-try-follow-nearest-node (&optional fork)
>
> Yes - the following seems simpler:
>
> !       (eq this-command 'Info-mouse-follow-nearest-node)
> ! 	(error "Point neither on reference nor in menu item description")))

Oops, yes of course.

> I'm not sure though whether we should raise an error for mouse-2 clicks.
> But I also fail to understand why we should raise an error at all.

I agree an error here is unnecessary and it would be better to remove
it.  I doubt any existing code depends on it.

Steve Berman

bug#886: 23.0.60; Info-mouse-follow-nearest-node fails

[martin rudalics]

> I agree an error here is unnecessary and it would be better to remove
> it.  I doubt any existing code depends on it.

I checked in a fix which doesn't raise an error when mouse-1 is involved.

Thanks, martin