From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1551: 23.0.60; declare-function: redundant `nil' arg Date: Fri, 12 Dec 2008 15:23:15 +0100 Message-ID: <87ej0dxyjw.fsf@escher.local.home> Reply-To: Stephen Berman , 1551@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1229094597 9421 80.91.229.12 (12 Dec 2008 15:09:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Dec 2008 15:09:57 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 12 16:11:02 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LB9fR-0002Vv-Tk for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Dec 2008 16:11:02 +0100 Original-Received: from localhost ([127.0.0.1]:49531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LB9eF-00074w-Fb for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Dec 2008 10:09:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LB9Z1-0003xr-Sh for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2008 10:04:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LB9Yz-0003wf-Tr for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2008 10:04:23 -0500 Original-Received: from [199.232.76.173] (port=56489 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LB9Yz-0003wX-Is for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2008 10:04:21 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35159) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LB9Yy-0000l1-TK for bug-gnu-emacs@gnu.org; Fri, 12 Dec 2008 10:04:21 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBCF4I7o031953; Fri, 12 Dec 2008 07:04:19 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBCF03Ru030726; Fri, 12 Dec 2008 07:00:03 -0800 X-Loop: don@donarmstrong.com Resent-From: Stephen Berman Original-Sender: steve@escher.local.home Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 12 Dec 2008 15:00:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1551 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122909368029187 (code B ref -1); Fri, 12 Dec 2008 15:00:03 +0000 X-Spam-Bayes: score:0.0000 Tokens: new, 125; hammy, 102; neutral, 67; spammy, 4. spammytokens:0.987-1--entry, 0.987-1--setup, 0.987-1--1623, 0.944-+--H*c:multipart hammytokens:0.000-+--emacs, 0.000-+--23.0.60, 0.000-+--23060, 0.000-+--Emacs, 0.000-+--H*M:fsf Original-Received: (at submit) by emacsbugs.donarmstrong.com; 12 Dec 2008 14:54:40 +0000 Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBCEsbvO029180 for ; Fri, 12 Dec 2008 06:54:38 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:52225) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LB9Ow-0005rO-MF for emacs-pretest-bug@gnu.org; Fri, 12 Dec 2008 09:53:58 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LB9PX-0007b8-EP for emacs-pretest-bug@gnu.org; Fri, 12 Dec 2008 09:54:37 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]:50019) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LB9PW-0007au-Jc for emacs-pretest-bug@gnu.org; Fri, 12 Dec 2008 09:54:35 -0500 Original-Received: (qmail invoked by alias); 12 Dec 2008 14:54:32 -0000 Original-Received: from i59F54B81.versanet.de (EHLO escher.local.home) [89.245.75.129] by mail.gmx.net (mp034) with SMTP; 12 Dec 2008 15:54:33 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX198pLBY3Fd86Ol2rknEeOV/dJWYFolPi8MoIwwwZy kQM9fB9fsuI/gz Original-Received: by escher.local.home (Postfix, from userid 1000) id 8BA8F7FF98; Fri, 12 Dec 2008 15:54:31 +0100 (CET) Resent-Sender: steve@escher.local.home Resent-To: emacs-pretest-bug@gnu.org Resent-From: Stephen Berman Resent-Date: Fri, 12 Dec 2008 15:54:31 +0100 Resent-Message-ID: <871vwdxx3s.fsf@escher.local.home> X-From-Line: nobody Fri Dec 12 15:23:15 2008 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Original-Lines: 119 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.64 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Fri, 12 Dec 2008 09:54:36 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23239 gmane.emacs.pretest.bugs:23490 Archived-At: --=-=-= In GNU Emacs 23.0.60.23 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2008-12-12 on escher According to the argument-list of declare-function, only its first two arguments are obligatory. But by rgrepping emacs/lisp for "(declare-function" I found four invocations with `nil' as the third argument (there are many more invocations with only two arguments): ./calendar/todo-mode.el:914:(declare-function calendar-current-date "calendar" nil) ./progmodes/fortran.el:917:(declare-function gud-find-c-expr "gud.el" nil) ./smerge-mode.el:1079:(declare-function ediff-cleanup-mess "ediff-util" nil) ./subr.el:2251:(declare-function w32-shell-dos-semantics "w32-fns" nil) Patches attached. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: smerge-mode.el patch *** /home/steve/cvsroot/emacs/lisp/smerge-mode.el.~1.74.~ 2008-11-04 21:09:18.000000000 +0100 --- /home/steve/cvsroot/emacs/lisp/smerge-mode.el 2008-12-12 15:03:30.000000000 +0100 *************** *** 1076,1082 **** (defvar ediff-buffer-C) (defvar ediff-ancestor-buffer) (defvar ediff-quit-hook) ! (declare-function ediff-cleanup-mess "ediff-util" nil) ;;;###autoload (defun smerge-ediff (&optional name-mine name-other name-base) --- 1076,1082 ---- (defvar ediff-buffer-C) (defvar ediff-ancestor-buffer) (defvar ediff-quit-hook) ! (declare-function ediff-cleanup-mess "ediff-util") ;;;###autoload (defun smerge-ediff (&optional name-mine name-other name-base) --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: subr.el patch *** /home/steve/cvsroot/emacs/lisp/subr.el.~1.623.~ 2008-11-20 13:49:52.000000000 +0100 --- /home/steve/cvsroot/emacs/lisp/subr.el 2008-12-12 15:04:49.000000000 +0100 *************** *** 2248,2254 **** (play-sound-internal sound) (error "This Emacs binary lacks sound support"))) ! (declare-function w32-shell-dos-semantics "w32-fns" nil) (defun shell-quote-argument (argument) "Quote an argument for passing as argument to an inferior shell." --- 2248,2254 ---- (play-sound-internal sound) (error "This Emacs binary lacks sound support"))) ! (declare-function w32-shell-dos-semantics "w32-fns") (defun shell-quote-argument (argument) "Quote an argument for passing as argument to an inferior shell." --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: todo-mode.el patch *** /home/steve/cvsroot/emacs/lisp/calendar/todo-mode.el.~1.71.~ 2008-10-25 20:48:16.000000000 +0200 --- /home/steve/cvsroot/emacs/lisp/calendar/todo-mode.el 2008-12-12 14:57:25.000000000 +0100 *************** *** 911,917 **** (defvar entry) ;; t-c should be used from diary code, which requires calendar. ! (declare-function calendar-current-date "calendar" nil) ;; Read about this function in the setup instructions above! ;;;###autoload --- 911,917 ---- (defvar entry) ;; t-c should be used from diary code, which requires calendar. ! (declare-function calendar-current-date "calendar") ;; Read about this function in the setup instructions above! ;;;###autoload --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: fortran.el patch *** /home/steve/cvsroot/emacs/lisp/progmodes/fortran.el.~1.151.~ 2008-11-20 13:49:53.000000000 +0100 --- /home/steve/cvsroot/emacs/lisp/progmodes/fortran.el 2008-12-12 14:59:26.000000000 +0100 *************** *** 914,920 **** "Fortran mode adds this to `hack-local-variables-hook'." (fortran-line-length fortran-line-length)) ! (declare-function gud-find-c-expr "gud.el" nil) (defun fortran-gud-find-expr () ;; Consider \n as punctuation (end of expression). --- 914,920 ---- "Fortran mode adds this to `hack-local-variables-hook'." (fortran-line-length fortran-line-length)) ! (declare-function gud-find-c-expr "gud.el") (defun fortran-gud-find-expr () ;; Consider \n as punctuation (end of expression). --=-=-=--