From: Stephen Berman <stephen.berman@gmx.net>
To: emacs-pretest-bug@gnu.org
Subject: bug#1551: 23.0.60; declare-function: redundant `nil' arg
Date: Fri, 12 Dec 2008 15:23:15 +0100 [thread overview]
Message-ID: <87ej0dxyjw.fsf@escher.local.home> (raw)
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
In GNU Emacs 23.0.60.23 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of
2008-12-12 on escher
According to the argument-list of declare-function, only its first two
arguments are obligatory. But by rgrepping emacs/lisp for
"(declare-function" I found four invocations with `nil' as the third
argument (there are many more invocations with only two arguments):
./calendar/todo-mode.el:914:(declare-function calendar-current-date "calendar" nil)
./progmodes/fortran.el:917:(declare-function gud-find-c-expr "gud.el" nil)
./smerge-mode.el:1079:(declare-function ediff-cleanup-mess "ediff-util" nil)
./subr.el:2251:(declare-function w32-shell-dos-semantics "w32-fns" nil)
Patches attached.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: smerge-mode.el patch --]
[-- Type: text/x-patch, Size: 686 bytes --]
*** /home/steve/cvsroot/emacs/lisp/smerge-mode.el.~1.74.~ 2008-11-04 21:09:18.000000000 +0100
--- /home/steve/cvsroot/emacs/lisp/smerge-mode.el 2008-12-12 15:03:30.000000000 +0100
***************
*** 1076,1082 ****
(defvar ediff-buffer-C)
(defvar ediff-ancestor-buffer)
(defvar ediff-quit-hook)
! (declare-function ediff-cleanup-mess "ediff-util" nil)
;;;###autoload
(defun smerge-ediff (&optional name-mine name-other name-base)
--- 1076,1082 ----
(defvar ediff-buffer-C)
(defvar ediff-ancestor-buffer)
(defvar ediff-quit-hook)
! (declare-function ediff-cleanup-mess "ediff-util")
;;;###autoload
(defun smerge-ediff (&optional name-mine name-other name-base)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: subr.el patch --]
[-- Type: text/x-patch, Size: 753 bytes --]
*** /home/steve/cvsroot/emacs/lisp/subr.el.~1.623.~ 2008-11-20 13:49:52.000000000 +0100
--- /home/steve/cvsroot/emacs/lisp/subr.el 2008-12-12 15:04:49.000000000 +0100
***************
*** 2248,2254 ****
(play-sound-internal sound)
(error "This Emacs binary lacks sound support")))
! (declare-function w32-shell-dos-semantics "w32-fns" nil)
(defun shell-quote-argument (argument)
"Quote an argument for passing as argument to an inferior shell."
--- 2248,2254 ----
(play-sound-internal sound)
(error "This Emacs binary lacks sound support")))
! (declare-function w32-shell-dos-semantics "w32-fns")
(defun shell-quote-argument (argument)
"Quote an argument for passing as argument to an inferior shell."
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: todo-mode.el patch --]
[-- Type: text/x-patch, Size: 694 bytes --]
*** /home/steve/cvsroot/emacs/lisp/calendar/todo-mode.el.~1.71.~ 2008-10-25 20:48:16.000000000 +0200
--- /home/steve/cvsroot/emacs/lisp/calendar/todo-mode.el 2008-12-12 14:57:25.000000000 +0100
***************
*** 911,917 ****
(defvar entry)
;; t-c should be used from diary code, which requires calendar.
! (declare-function calendar-current-date "calendar" nil)
;; Read about this function in the setup instructions above!
;;;###autoload
--- 911,917 ----
(defvar entry)
;; t-c should be used from diary code, which requires calendar.
! (declare-function calendar-current-date "calendar")
;; Read about this function in the setup instructions above!
;;;###autoload
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #5: fortran.el patch --]
[-- Type: text/x-patch, Size: 745 bytes --]
*** /home/steve/cvsroot/emacs/lisp/progmodes/fortran.el.~1.151.~ 2008-11-20 13:49:53.000000000 +0100
--- /home/steve/cvsroot/emacs/lisp/progmodes/fortran.el 2008-12-12 14:59:26.000000000 +0100
***************
*** 914,920 ****
"Fortran mode adds this to `hack-local-variables-hook'."
(fortran-line-length fortran-line-length))
! (declare-function gud-find-c-expr "gud.el" nil)
(defun fortran-gud-find-expr ()
;; Consider \n as punctuation (end of expression).
--- 914,920 ----
"Fortran mode adds this to `hack-local-variables-hook'."
(fortran-line-length fortran-line-length))
! (declare-function gud-find-c-expr "gud.el")
(defun fortran-gud-find-expr ()
;; Consider \n as punctuation (end of expression).
next reply other threads:[~2008-12-12 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <078wqlky82.fsf@fencepost.gnu.org>
2008-12-12 14:23 ` Stephen Berman [this message]
2008-12-12 19:15 ` bug#1551: marked as done (23.0.60; declare-function: redundant `nil' arg) Emacs bug Tracking System
2008-12-12 19:15 ` Processed: Re: bug#1551: 23.0.60; declare-function: redundant `nil' arg Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ej0dxyjw.fsf@escher.local.home \
--to=stephen.berman@gmx.net \
--cc=1551@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.