From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#2833: 23.0.92; Bug in Directory Variables Date: Thu, 09 Apr 2009 11:20:13 -0400 Message-ID: <87eiw1vope.fsf@cyd.mit.edu> References: <87fxgicz1b.fsf@cyd.mit.edu> Reply-To: Chong Yidong , 2833@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1239292394 2516 80.91.229.12 (9 Apr 2009 15:53:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Apr 2009 15:53:14 +0000 (UTC) Cc: 2833@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 09 17:54:33 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LrwaD-0004zP-UP for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Apr 2009 17:54:30 +0200 Original-Received: from localhost ([127.0.0.1]:44419 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrwYp-0008AL-GG for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Apr 2009 11:53:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrwQ1-00077d-0o for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 11:43:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrwPw-00071O-Bh for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 11:43:56 -0400 Original-Received: from [199.232.76.173] (port=51813 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrwPv-000715-PV for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 11:43:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43377) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LrwPv-0001tb-93 for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2009 11:43:51 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39Fhnra020970; Thu, 9 Apr 2009 08:43:49 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n39FP6Zt014718; Thu, 9 Apr 2009 08:25:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 09 Apr 2009 15:25:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2833 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2833-submit@emacsbugs.donarmstrong.com id=B2833.123929031412619 (code B ref 2833); Thu, 09 Apr 2009 15:25:06 +0000 Original-Received: (at 2833) by emacsbugs.donarmstrong.com; 9 Apr 2009 15:18:34 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n39FIVfB012608 for <2833@emacsbugs.donarmstrong.com>; Thu, 9 Apr 2009 08:18:32 -0700 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 76EF157E24C; Thu, 9 Apr 2009 11:20:13 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Thu, 09 Apr 2009 10:27:22 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 09 Apr 2009 11:43:56 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27028 Archived-At: Stefan Monnier writes: > - We don't know that the (float-time) is in sync with the filesystem's > time, so the check may not work right. Better check the file's > current mtime against the file's mtime when it was last read. Yes, good point. > - the variable you changed could previously be setq in the .emacs, > whereas you changed it into an internal var. It was always a defvar instead of a defcustom. I don't think it makes sense for it to be user-customizable. > FWIW, here's the patch I was working on instead. Is this patch complete? By the time dir-locals-read-from-file is called, hack-dir-local-variables has already decided that there is no cached value. Conversely, if there is a cached value, it will be used without calling dir-locals-read-from-file. So we need to change dir-locals-find-file as well (which is what my patch did).