From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 2833@emacsbugs.donarmstrong.com
Subject: bug#2833: 23.0.92; Bug in Directory Variables
Date: Thu, 09 Apr 2009 11:20:13 -0400 [thread overview]
Message-ID: <87eiw1vope.fsf@cyd.mit.edu> (raw)
In-Reply-To: <jwv63hdapcn.fsf-monnier+gnus-read-ephemeral-bug@gnu.org> (Stefan Monnier's message of "Thu, 09 Apr 2009 10:27:22 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> - We don't know that the (float-time) is in sync with the filesystem's
> time, so the check may not work right. Better check the file's
> current mtime against the file's mtime when it was last read.
Yes, good point.
> - the variable you changed could previously be setq in the .emacs,
> whereas you changed it into an internal var.
It was always a defvar instead of a defcustom. I don't think it makes
sense for it to be user-customizable.
> FWIW, here's the patch I was working on instead.
Is this patch complete? By the time dir-locals-read-from-file is
called, hack-dir-local-variables has already decided that there is no
cached value. Conversely, if there is a cached value, it will be used
without calling dir-locals-read-from-file. So we need to change
dir-locals-find-file as well (which is what my patch did).
next prev parent reply other threads:[~2009-04-09 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 2:59 23.0.92; Bug in Directory Variables Chong Yidong
2009-04-09 11:03 ` David De La Harpe Golden
2009-04-09 11:03 ` bug#2833: " David De La Harpe Golden
2009-04-09 14:27 ` Stefan Monnier
2009-04-09 15:20 ` Chong Yidong [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-11 15:31 Chong Yidong
2009-04-12 13:22 ` Leo
2009-04-09 2:59 Chong Yidong
2009-04-09 11:31 ` Leo
2009-04-02 18:50 Chong Yidong
2009-03-31 14:32 Leo
2009-04-01 1:14 ` Stefan Monnier
2009-04-01 10:01 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eiw1vope.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=2833@emacsbugs.donarmstrong.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.