NS Port keeps crashing when FN key combo is pressed.

NS Port keeps crashing when FN key combo is pressed.

[Jimmy Yuen Ho Wong]

Sometime since the last change few changes in nsterm.m, whenever I hit a 
function key combo, Emacs.app immediately crashes with no stack trace. 
I'm not sure what's happening.

I'm running on Mac OS X 10.5.8 PPC.


-- 
Jimmy Yuen Ho Wong

Re: NS Port keeps crashing when FN key combo is pressed.

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

On Jan 14, 2010, at 4:48 PM, Jimmy Yuen Ho Wong wrote:

> Sometime since the last change few changes in nsterm.m, whenever I hit a function key combo, Emacs.app immediately crashes with no stack trace. I'm not sure what's happening.
> 
> I'm running on Mac OS X 10.5.8 PPC.


Indeed it crashes, but getting a trace was no problem for me.

Try the patch below, which fixes the issue for me.
(I believe it does not need a Qmodifier_value attribute, as the function modifier isn't checked in xterm.c.)

- David


 
diff --git a/src/nsterm.m b/src/nsterm.m
index ff2e47a..ce6cca5 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6707,6 +6707,7 @@ syms_of_nsterm ()
   DEFSYM (Qmeta, "meta");
   DEFSYM (Qsuper, "super");
   DEFSYM (Qcontrol, "control");
+  DEFSYM (Qnone, "none");
   Fput (Qalt, Qmodifier_value, make_number (alt_modifier));
   Fput (Qhyper, Qmodifier_value, make_number (hyper_modifier));
   Fput (Qmeta, Qmodifier_value, make_number (meta_modifier));



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 203 bytes --]

Re: NS Port keeps crashing when FN key combo is pressed.

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

Could someone ob bzr please apply the patch below?

syms_of_nsterm: define Qnone symbol.


diff --git a/src/nsterm.m b/src/nsterm.m
index ff2e47a..ce6cca5 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6707,6 +6707,7 @@ syms_of_nsterm ()
   DEFSYM (Qmeta, "meta");
   DEFSYM (Qsuper, "super");
   DEFSYM (Qcontrol, "control");
+  DEFSYM (Qnone, "none");
   Fput (Qalt, Qmodifier_value, make_number (alt_modifier));
   Fput (Qhyper, Qmodifier_value, make_number (hyper_modifier));
   Fput (Qmeta, Qmodifier_value, make_number (meta_modifier));



On Jan 14, 2010, at 7:32 PM, Jimmy Yuen Ho Wong wrote:

> Yep this patch fixed it. Thanks!
> 
> JW
> 
> On 1/14/10 5:54 PM, David Reitter wrote:
>> On Jan 14, 2010, at 4:48 PM, Jimmy Yuen Ho Wong wrote:
>> 
>>> Sometime since the last change few changes in nsterm.m, whenever I hit a function key combo, Emacs.app immediately crashes with no stack trace. I'm not sure what's happening.
>>> 
>>> I'm running on Mac OS X 10.5.8 PPC.
>> 
>> 
>> Indeed it crashes, but getting a trace was no problem for me.
>> 
>> Try the patch below, which fixes the issue for me.
>> (I believe it does not need a Qmodifier_value attribute, as the function modifier isn't checked in xterm.c.)
>> 
>> - David


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 203 bytes --]

Re: NS Port keeps crashing when FN key combo is pressed.

[Chong Yidong]

David Reitter <david.reitter@gmail.com> writes:

> Could someone ob bzr please apply the patch below?
>
> syms_of_nsterm: define Qnone symbol.

Thanks.  I checked in a slightly different patch.  The Qnone variable
needed to be moved over from nsfns.m.