From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5475: Archives with filenames with square brackets Date: Tue, 26 Jan 2010 16:05:20 -0500 Message-ID: <87eilca86n.fsf@stupidchicken.com> References: <874omakv2m.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264540229 16016 80.91.229.12 (26 Jan 2010 21:10:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jan 2010 21:10:29 +0000 (UTC) Cc: 5475@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 26 22:10:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NZsfs-0003fL-Go for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2010 22:10:12 +0100 Original-Received: from localhost ([127.0.0.1]:48990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZsft-0001r6-FK for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2010 16:10:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZsfe-0001e2-3F for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:58 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZsfZ-0001YR-5b for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:57 -0500 Original-Received: from [199.232.76.173] (port=34112 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZsfZ-0001YJ-1T for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:53 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49196) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZsfY-0003vn-RU for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2010 16:09:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZsbq-0005J6-79; Tue, 26 Jan 2010 16:06:02 -0500 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: <874omakv2m.fsf@mail.jurta.org> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2010 21:06:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5475 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5475-submit@debbugs.gnu.org id=B5475.126453992820371 (code B ref 5475); Tue, 26 Jan 2010 21:06:02 +0000 Original-Received: (at 5475) by debbugs.gnu.org; 26 Jan 2010 21:05:28 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZsbG-0005IW-Vs for submit@debbugs.gnu.org; Tue, 26 Jan 2010 16:05:27 -0500 Original-Received: from pantheon-po29.its.yale.edu ([130.132.50.124]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZsbF-0005IP-0D for 5475@debbugs.gnu.org; Tue, 26 Jan 2010 16:05:25 -0500 Original-Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po29.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0QL5KOF024957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 26 Jan 2010 16:05:20 -0500 Original-Received: by furry (Postfix, from userid 1000) id 38115C05D; Tue, 26 Jan 2010 14:05:20 -0700 (MST) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -4.9 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -4.9 (----) Resent-Date: Tue, 26 Jan 2010 16:06:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34732 Archived-At: > When a zip archive contains a file with square brackets in its name > (e.g. "file[name].txt") then visiting this file displays an error: > > caution: filename not matched: file[name].txt I assume this is a specific quirk of unzip that it handles square brackets specially (characters like * seem to be handled literally). How about this patch? *** lisp/arc-mode.el 2010-01-13 08:35:10 +0000 --- lisp/arc-mode.el 2010-01-26 21:03:54 +0000 *************** *** 1782,1787 **** --- 1782,1791 ---- (apply 'vector (nreverse files)))) (defun archive-zip-extract (archive name) + (when (string-match "[][]" name) + (require 'comint) + (let ((comint-file-name-quote-list '(?\] ?\[))) + (setq name (comint-quote-filename name)))) (if (equal (car archive-zip-extract) "pkzip") (archive-*-extract archive name archive-zip-extract) (archive-extract-by-stdout archive name archive-zip-extract)))