all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Andy Moreton <andrewjmoreton@googlemail.com>
Cc: 5730@debbugs.gnu.org
Subject: bug#5730: 23.1.94; Emacs crash running gnus on Windows
Date: Wed, 24 Mar 2010 17:37:13 -0400	[thread overview]
Message-ID: <87eij9e706.fsf@stupidchicken.com> (raw)
In-Reply-To: <4B9F7D16.6050407@gmail.com>

I've checked a change into the bzr branch; could you verify if it fixes
the problem?  If it's inconvenient for you to check out the bzr branch,
try the patch below:

*** xdisp.c	2010-03-10 21:20:33.000000000 -0500
--- xdisp.c	2010-03-24 17:22:37.000000000 -0400
***************
*** 1375,1407 ****
  	visible_p = 1;
        if (visible_p)
  	{
! 	  if (it_method == GET_FROM_BUFFER)
! 	    {
! 	      Lisp_Object window, prop;
! 
! 	      XSETWINDOW (window, w);
! 	      prop = Fget_char_property (make_number (charpos),
! 					 Qinvisible, window);
! 
! 	      /* If charpos coincides with invisible text covered with an
! 		 ellipsis, use the first glyph of the ellipsis to compute
! 		 the pixel positions.  */
! 	      if (TEXT_PROP_MEANS_INVISIBLE (prop) == 2)
! 		{
! 		  struct glyph_row *row = it.glyph_row;
! 		  struct glyph *glyph = row->glyphs[TEXT_AREA];
! 		  struct glyph *end = glyph + row->used[TEXT_AREA];
! 		  int x = row->x;
! 
! 		  for (; glyph < end
! 			 && (!BUFFERP (glyph->object)
! 			     || glyph->charpos < charpos);
! 		       glyph++)
! 		    x += glyph->pixel_width;
! 		  top_x = x;
! 		}
! 	    }
! 	  else if (it_method == GET_FROM_DISPLAY_VECTOR)
  	    {
  	      /* We stopped on the last glyph of a display vector.
  		 Try and recompute.  Hack alert!  */
--- 1375,1381 ----
  	visible_p = 1;
        if (visible_p)
  	{
! 	  if (it_method == GET_FROM_DISPLAY_VECTOR)
  	    {
  	      /* We stopped on the last glyph of a display vector.
  		 Try and recompute.  Hack alert!  */






  reply	other threads:[~2010-03-24 21:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 12:44 bug#5730: 23.1.94; Emacs crash running gnus on Windows Andy Moreton
2010-03-24 21:37 ` Chong Yidong [this message]
2010-03-24 23:45   ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eij9e706.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=5730@debbugs.gnu.org \
    --cc=andrewjmoreton@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.