From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top' Date: Tue, 30 Mar 2010 22:41:11 +0800 Message-ID: <87eij1swhk.fsf@home.jasonrumney.net> References: <87pr38rnan.fsf@stupidchicken.com> <83pr2mympy.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1269960616 7872 80.91.229.12 (30 Mar 2010 14:50:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 30 Mar 2010 14:50:16 +0000 (UTC) Cc: Chong Yidong , 5703@debbugs.gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 30 16:50:11 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwcld-0007Dr-Oy for ged-emacs-devel@m.gmane.org; Tue, 30 Mar 2010 16:50:10 +0200 Original-Received: from localhost ([127.0.0.1]:54724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nwcld-0008Tk-8y for ged-emacs-devel@m.gmane.org; Tue, 30 Mar 2010 10:50:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwcdM-0008GH-21 for emacs-devel@gnu.org; Tue, 30 Mar 2010 10:41:36 -0400 Original-Received: from [140.186.70.92] (port=58274 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwcdH-0008EY-Ot for emacs-devel@gnu.org; Tue, 30 Mar 2010 10:41:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwcdD-0003Ec-CA for emacs-devel@gnu.org; Tue, 30 Mar 2010 10:41:31 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.158]:12385) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwcd6-0003Cw-9a; Tue, 30 Mar 2010 10:41:20 -0400 Original-Received: by fg-out-1718.google.com with SMTP id d23so100012fga.12 for ; Tue, 30 Mar 2010 07:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:from:to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=lbm4dVTjEkTNhl0i+dS1qEqQ+8OtvUgssbJXcQO6BD0=; b=a2aljqa2RcYl1hoExdThFl8BRgObqkWddlfQU+6f9vrrwlllLGFN6EMzMoGfT/wYb1 CvlW5XNIDHTtfpUFUksrHq3CTmhIw0au+Jh6fg68jQeXB/v1feS4tUtyiYpDljg1TDfZ dUUPQmfbC80PWDXvp8jgk2fhFHLoxteygIr4M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=tVz1ssK0uWOEwelJbpy00uP3dYZVJaE61q01gVz7hj+uQnz9r+Uup0MsvGIRJVnC9c g9+pOjuGEnJxuoHAXXF+pDXAv2GkKwUEpBWq9e0uF92Ut+QDYPe5FzWNP3YUo78OFHoe 1WSUFRuM0beYm/OBqGDhAcGMiGVqei3g0qWoo= Original-Received: by 10.87.17.34 with SMTP id u34mr139673fgi.10.1269960079204; Tue, 30 Mar 2010 07:41:19 -0700 (PDT) Original-Received: from home.jasonrumney.net ([202.87.221.133]) by mx.google.com with ESMTPS id 14sm3980394fxm.1.2010.03.30.07.41.17 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Mar 2010 07:41:17 -0700 (PDT) Original-Received: by home.jasonrumney.net (Postfix, from userid 1000) id C6B961343; Tue, 30 Mar 2010 22:41:11 +0800 (MYT) In-Reply-To: <83pr2mympy.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Mar 2010 16:15:37 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122912 Archived-At: Eli Zaretskii writes: > I think the small patch below fixes this. But since this is about > pretest, I would like second opinion on that from anyone who is > familiar with this stuff (not only on MS-Windows). In particular, I'd > like to hear from Jason. If I understand your patch correctly, what you are effectively doing is to compute the x and y location of the tooltip, then patch it up afterwards if explicit arguments were given. This seems ok for a temporary workaround until the reason Windows behaviour differs from other plaforms can be found. > === modified file 'src/w32fns.c' > --- src/w32fns.c 2010-01-13 08:35:10 +0000 > +++ src/w32fns.c 2010-03-30 12:57:13 +0000 > @@ -5927,6 +5927,10 @@ Text larger than the specified size is c > /* Move the tooltip window where the mouse pointer is. Resize and > show it. */ > compute_tip_xy (f, parms, dx, dy, width, height, &root_x, &root_y); > + if (f->top_pos) > + root_y = f->top_pos; > + if (f->left_pos) > + root_x = f->left_pos; > > { > /* Adjust Window size to take border into account. */