From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Teemu Likonen Newsgroups: gmane.emacs.bugs Subject: bug#6632: 23.2.50; dired-mode should use [remap ...] instead of hard-coded overriding of global key bindings Date: Wed, 14 Jul 2010 18:58:13 +0300 Message-ID: <87eif6ukbu.fsf@mithlond.arda> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1279125052 15208 80.91.229.12 (14 Jul 2010 16:30:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 16:30:52 +0000 (UTC) To: 6632@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 14 18:30:48 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4r9-0005FS-UY for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jul 2010 18:30:48 +0200 Original-Received: from localhost ([127.0.0.1]:43582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ4r7-00066k-Q3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jul 2010 12:30:45 -0400 Original-Received: from [140.186.70.92] (port=53013 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ4qy-00065i-Lu for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:30:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZ4qx-00053F-6c for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:30:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47517) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4qx-00053B-5G for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:30:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OZ4OL-0006ry-Ns; Wed, 14 Jul 2010 12:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Teemu Likonen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jul 2010 16:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.127912320724236 (code B ref -1); Wed, 14 Jul 2010 16:01:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jul 2010 16:00:07 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4NS-0006IL-De for submit@debbugs.gnu.org; Wed, 14 Jul 2010 12:00:06 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4NP-0006F6-D7 for submit@debbugs.gnu.org; Wed, 14 Jul 2010 12:00:04 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:45273) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OZ4NX-0006Op-CQ for submit@debbugs.gnu.org; Wed, 14 Jul 2010 12:00:11 -0400 Original-Received: from [140.186.70.92] (port=54349 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ4NV-0002HK-Ia for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:00:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZ4NT-0008Mi-Ur for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:00:09 -0400 Original-Received: from mta-out.inet.fi ([195.156.147.13]:33098 helo=kirsi2.inet.fi) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ4NT-00081w-Gi for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:00:07 -0400 Original-Received: from mithlond.arda (84.251.132.215) by kirsi2.inet.fi (8.5.122) id 4C33307D0037BBC0 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 18:58:28 +0300 Original-Received: from dtw by mithlond.arda with local (Exim 4.69) (envelope-from ) id 1OZ4Ld-0004gk-5M for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 18:58:13 +0300 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 14 Jul 2010 12:01:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38515 Archived-At: --=-=-= dired-mode uses hard-coding when it rebinds some global key bindings. For example, there is the following line in dired.el file: (define-key map "\C-n" 'dired-next-line) Therefore it overrides the global C-n key, whatever its command is in user's keymap. The command should be bound like this: (define-key map [remap next-line] 'dired-next-line) Using [remap ...] is preferred because it makes it possible for user to redefine the global keymap they way she wishes and keys will still automatically get their mode-specific behaviour. The attached patch fixes this for dired-mode. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=dired-mode-remap.diff diff --git a/lisp/dired.el b/lisp/dired.el index c3d1435..0e5cc22 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1380,10 +1380,8 @@ Do so according to the former subdir alist OLD-SUBDIR-ALIST." (define-key map ">" 'dired-next-dirline) (define-key map "^" 'dired-up-directory) (define-key map " " 'dired-next-line) - (define-key map "\C-n" 'dired-next-line) - (define-key map "\C-p" 'dired-previous-line) - (define-key map [down] 'dired-next-line) - (define-key map [up] 'dired-previous-line) + (define-key map [remap next-line] 'dired-next-line) + (define-key map [remap previous-line] 'dired-previous-line) ;; hiding (define-key map "$" 'dired-hide-subdir) (define-key map "\M-$" 'dired-hide-all) @@ -1393,7 +1391,7 @@ Do so according to the former subdir alist OLD-SUBDIR-ALIST." (define-key map (kbd "M-s f C-s") 'dired-isearch-filenames) (define-key map (kbd "M-s f M-C-s") 'dired-isearch-filenames-regexp) ;; misc - (define-key map "\C-x\C-q" 'dired-toggle-read-only) + (define-key map [remap toggle-read-only] 'dired-toggle-read-only) (define-key map "?" 'dired-summary) (define-key map "\177" 'dired-unmark-backward) (define-key map [remap undo] 'dired-undo) --=-=-=--