From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows/MS-DOS Date: Tue, 20 Jul 2010 21:51:39 +0200 Message-ID: <87eiey2apg.fsf@telefonica.net> References: <878w564xtc.fsf@telefonica.net> <87vd8a2rxg.fsf@telefonica.net> <87r5iy2ptw.fsf@telefonica.net> <83vd8acbbv.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279656050 12149 80.91.229.12 (20 Jul 2010 20:00:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 20 Jul 2010 20:00:50 +0000 (UTC) Cc: lekktu@gmail.com, 6674@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 20 22:00:48 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ObIzf-0007Zj-87 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jul 2010 22:00:47 +0200 Original-Received: from localhost ([127.0.0.1]:60947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObIze-0007n3-Lq for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jul 2010 16:00:46 -0400 Original-Received: from [140.186.70.92] (port=34400 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObIzZ-0007mx-Li for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2010 16:00:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObIzY-0005lZ-H1 for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2010 16:00:41 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33803) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObIzY-0005lU-7A for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2010 16:00:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1ObIrC-0004qN-Ir; Tue, 20 Jul 2010 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jul 2010 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6674 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6674-submit@debbugs.gnu.org id=B6674.127965547918611 (code B ref 6674); Tue, 20 Jul 2010 19:52:02 +0000 Original-Received: (at 6674) by debbugs.gnu.org; 20 Jul 2010 19:51:19 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObIqV-0004q8-DF for submit@debbugs.gnu.org; Tue, 20 Jul 2010 15:51:19 -0400 Original-Received: from impaqm2.telefonica.net ([213.4.138.2]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObIqT-0004q2-Br for 6674@debbugs.gnu.org; Tue, 20 Jul 2010 15:51:18 -0400 Original-Received: from IMPmailhost3.adm.correo ([10.20.102.124]) by IMPaqm2.telefonica.net with bizsmtp id kKRV1e00G2h2L9m3MKrhRW; Tue, 20 Jul 2010 21:51:41 +0200 Original-Received: from qcore ([83.42.13.171]) by IMPmailhost3.adm.correo with BIZ IMP id kKrf1e00H3hRxRf1jKrgMJ; Tue, 20 Jul 2010 21:51:41 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="981711563$telefonica.net" |auth_email="981711563@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" In-Reply-To: <83vd8acbbv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Jul 2010 20:28:04 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 20 Jul 2010 15:52:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38700 Archived-At: Eli Zaretskii writes: [snip] > By trial and error I established that the limit beyond which rgrep > fails is 1024 characters. This is consistent with the MSDN > documentation of _spawn, e.g. [snip] > So we could either (1) install =C3=93scar's patch, with the disadvantage > that rgrep will be slower on MS-Windows (because a separate Grep is > invoked on each file found by Find), or (2) fix cmdproxy to use a > better API, such as CreateProcess, which doesn't have this limitation. cmdproxy.c does not call the C runtime `_spawn' function. It defines its own `spawn' that calls CreateProcess. The issue is that "cmd.exe -c" seems to have a 1024 char limit when the command contains a pipe (my guess is that the limit applies separatelly to every command on the pipe chain) and cmdproxy.c prepends "cmd.exe -c" to the command when it has a pipe, redirection, etc. > In any case, please do NOT install the patch for the MS-DOS build. As > I wrote earlier, it does not have this problem. Okay.