From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#7587: 23.2; `format-mode-line' makes Emacs crash Date: Thu, 16 Dec 2010 10:17:51 +0800 Message-ID: <87ei9icvg0.fsf@stupidchicken.com> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1292466176 1670 80.91.229.12 (16 Dec 2010 02:22:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 16 Dec 2010 02:22:56 +0000 (UTC) Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org, Miles Bader To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 16 03:22:51 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3UV-0008Pk-2a for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Dec 2010 03:22:47 +0100 Original-Received: from localhost ([127.0.0.1]:43008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PT3UU-0004Gn-5w for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Dec 2010 21:22:46 -0500 Original-Received: from [140.186.70.92] (port=35728 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PT3UO-0004DC-W2 for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2010 21:22:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PT3UN-0006pr-Tb for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2010 21:22:40 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PT3UN-0006pi-Pd for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2010 21:22:39 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PT3K5-0000CF-R9; Wed, 15 Dec 2010 21:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Dec 2010 02:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7587-submit@debbugs.gnu.org id=B7587.1292465502719 (code B ref 7587); Thu, 16 Dec 2010 02:12:01 +0000 Original-Received: (at 7587) by debbugs.gnu.org; 16 Dec 2010 02:11:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3Jl-0000BY-1Q for submit@debbugs.gnu.org; Wed, 15 Dec 2010 21:11:41 -0500 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3Jj-0000BM-Aq for 7587@debbugs.gnu.org; Wed, 15 Dec 2010 21:11:39 -0500 Original-Received: from furball (bb121-6-218-24.singnet.com.sg [121.6.218.24]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBG2Hr1X011548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 15 Dec 2010 21:17:56 -0500 Original-Received: by furball (Postfix, from userid 1000) id AE7E3161788; Wed, 15 Dec 2010 21:17:51 -0500 (EST) In-Reply-To: <83fwu51cc1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Dec 2010 00:40:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 15 Dec 2010 21:12:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42542 Archived-At: Eli Zaretskii writes: > The call to lookup_basic_face comes from init_iterator: > init_iterator does this because it expects a truly basic face in > base_face_id, and it wants to use its face-remapped variety, as the > user would expect. But in this case, we pass to it an already > remapped basic face, see this part of format-mode-line: > lookup_named_face returns the face ID of the remapped mode-line face. > So in this case, face_id is already an ID of the remapped mode-line > face, and returning it unaltered from lookup_basic_face is TRT. format-mode-line should not pass non-basic faces to init_iterator. I'm not even sure what the FACE argument to format-mode-line is useful for; it doesn't seem to be used anywhere in the sources. I've changed format-mode-line so that if you pass a face argument to FACES, it should be one of `default', `mode-line', etc. Any other face gets treated as `default'.