From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org,
Miles Bader <miles@gnu.org>
Subject: bug#7587: 23.2; `format-mode-line' makes Emacs crash
Date: Thu, 16 Dec 2010 10:17:51 +0800 [thread overview]
Message-ID: <87ei9icvg0.fsf@stupidchicken.com> (raw)
In-Reply-To: <83fwu51cc1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Dec 2010 00:40:14 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> The call to lookup_basic_face comes from init_iterator:
> init_iterator does this because it expects a truly basic face in
> base_face_id, and it wants to use its face-remapped variety, as the
> user would expect. But in this case, we pass to it an already
> remapped basic face, see this part of format-mode-line:
> lookup_named_face returns the face ID of the remapped mode-line face.
> So in this case, face_id is already an ID of the remapped mode-line
> face, and returning it unaltered from lookup_basic_face is TRT.
format-mode-line should not pass non-basic faces to init_iterator. I'm
not even sure what the FACE argument to format-mode-line is useful for;
it doesn't seem to be used anywhere in the sources.
I've changed format-mode-line so that if you pass a face argument to
FACES, it should be one of `default', `mode-line', etc. Any other face
gets treated as `default'.
next prev parent reply other threads:[~2010-12-16 2:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 21:01 bug#7587: 23.2; `format-mode-line' makes Emacs crash Michael Heerdegen
2010-12-10 16:02 ` Eli Zaretskii
2010-12-10 16:39 ` Eli Zaretskii
2010-12-10 20:50 ` Stefan Monnier
2010-12-10 22:40 ` Eli Zaretskii
2010-12-16 2:17 ` Chong Yidong [this message]
2010-12-16 4:39 ` Drew Adams
2010-12-16 5:37 ` Eli Zaretskii
2010-12-16 5:35 ` Eli Zaretskii
2010-12-18 8:56 ` Eli Zaretskii
2010-12-20 15:29 ` Chong Yidong
2010-12-20 18:33 ` Eli Zaretskii
2010-12-25 10:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei9icvg0.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=7587@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.