From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#10160: 24.0.91; diff-hunk-file-names returns quoted file names Date: Tue, 29 Nov 2011 20:01:21 +0100 Message-ID: <87ehwqlpmm.fsf@gmx.de> References: <871usr410u.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1322593334 24622 80.91.229.12 (29 Nov 2011 19:02:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Nov 2011 19:02:14 +0000 (UTC) Cc: 10160@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 29 20:02:10 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVSwS-000676-TQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 20:02:09 +0100 Original-Received: from localhost ([::1]:35426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVSwS-0006sY-Hh for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 14:02:08 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:57148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVSwM-0006sO-R8 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 14:02:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVSwL-0003Uz-Ei for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 14:02:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVSwL-0003Ur-DA for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 14:02:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVSyH-0006hJ-So for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 14:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2011 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10160 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10160-submit@debbugs.gnu.org id=B10160.132259341425708 (code B ref 10160); Tue, 29 Nov 2011 19:04:01 +0000 Original-Received: (at 10160) by debbugs.gnu.org; 29 Nov 2011 19:03:34 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVSxo-0006ga-8Q for submit@debbugs.gnu.org; Tue, 29 Nov 2011 14:03:33 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1RVSxj-0006gQ-MS for 10160@debbugs.gnu.org; Tue, 29 Nov 2011 14:03:29 -0500 Original-Received: (qmail invoked by alias); 29 Nov 2011 19:01:24 -0000 Original-Received: from p57BB98FE.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.152.254] by mail.gmx.net (mp038) with SMTP; 29 Nov 2011 20:01:24 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18DNlE0szYDbn3iC+zi3oI/teW3uYtOfBdrI4hFaa q+i+PEgg3H7IFV In-Reply-To: (Stefan Monnier's message of "Tue, 29 Nov 2011 13:50:00 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 29 Nov 2011 14:04:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54436 Archived-At: Stefan Monnier writes: >> diff-hunk-file-names reads file names from the *Diff* buffer. The first >> line (the diff command itself) can contain labels, marked with -L. If >> these labels contains quoted characters like in remote file names, the >> quotation is returned. Example: > >> diff -c -L /ftp\:slbhao\:/home/albinus/src/tramp/lisp/tramp.el -L >> /ftp\:slbhao\:/home/albinus/src/emacs/lisp/net/tramp.el >> /tmp/ange-ftp13518wvE.el /tmp/ange-ftp1351895K.el > >> Such quoted file names result in problems when used as parameter for >> file name functions, like in diff-find-file-name. > > Not sure what to do about them: this "parsing the diff command line" is > brittle in any case because this line is printed by various tools, and > I don't think they're very consistent in how they handle quoting. > We should probably try to minimize the problem first, by using relative > file names when possible. In my use case, it was superfluous, because the correct file names are also parsed in the diff output (thanks to the -L label option). I don't know whether we could generalize this, trusting just the given file names of the diff result. (And, btw, ediff could also use the -L argument. This would look better than the local temp file names, as produced by Tramp for remote files. But this is another story). > Stefan Best regards, Michael.