bug#12347: 24.2.50; doc of `completion-table-subvert'

bug#12347: 24.2.50; doc of `completion-table-subvert'

[Drew Adams]

Doc string:
 
"Completion table that replaces the prefix S1 with S2 in STRING."
 
What's STRING?  STRING is described/defined nowhere.  And this is the
first sentence of the doc string, which should be able to stand alone.

In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
 of 2012-09-02 on MARVIN
Bzr revision: 109861 eggert@cs.ucla.edu-20120902171035-7mzihil3xd6bjfiy
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 

bug#12347: 24.2.50; doc of `completion-table-subvert'

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

"Drew Adams" <drew.adams@oracle.com> writes:

> "Completion table that replaces the prefix S1 with S2 in STRING."

I applied the patch below.

Thanks,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: minibuffer.el.patch --]
[-- Type: text/x-patch, Size: 826 bytes --]

=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el	2012-09-01 04:28:24 +0000
+++ lisp/minibuffer.el	2012-09-11 14:05:33 +0000
@@ -211,10 +211,10 @@
       (complete-with-action action table string pred))))
 
 (defun completion-table-subvert (table s1 s2)
-  "Completion table that replaces the prefix S1 with S2 in STRING.
+  "Return a completion table from TABLE with S1 replaced by S2.
 The result is a completion table which completes strings of the
-form (concat S1 S) in the same way as TABLE completes strings of
-the form (concat S2 S)."
+form (concat S2 S) in the same way as TABLE completes strings of
+the form (concat S1 S)."
   (lambda (string pred action)
     (let* ((str (if (eq t (compare-strings string 0 (length s1) s1 nil nil
                                            completion-ignore-case))


[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

bug#12347: 24.2.50; doc of `completion-table-subvert'

[Drew Adams]

> I applied the patch below.

Looks good; thanks.

bug#12347: 24.2.50; doc of `completion-table-subvert'

[Stefan Monnier]

> -form (concat S1 S) in the same way as TABLE completes strings of
> -the form (concat S2 S)."
> +form (concat S2 S) in the same way as TABLE completes strings of
> +the form (concat S1 S)."

That's wrong.  Check the code: it's (concat S2 S), aka `str', which is
passed to TABLE, not (concat S1 S).


        Stefan

bug#12347: 24.2.50; doc of `completion-table-subvert'

[Bastien]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> -form (concat S1 S) in the same way as TABLE completes strings of
>> -the form (concat S2 S)."
>> +form (concat S2 S) in the same way as TABLE completes strings of
>> +the form (concat S1 S)."
>
> That's wrong.  Check the code: it's (concat S2 S), aka `str', which is
> passed to TABLE, not (concat S1 S).

Indeed.  Fixed,

-- 
 Bastien