From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Romain Francoise Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] POSIX ACL support Date: Mon, 19 Nov 2012 22:33:16 +0100 Organization: orebokech dot com Message-ID: <87ehjpp9b7.fsf@silenus.orebokech.com> References: <878v9yr1h1.fsf@silenus.orebokech.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353360808 12884 80.91.229.3 (19 Nov 2012 21:33:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2012 21:33:28 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 19 22:33:35 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TaYyE-0004cN-KC for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2012 22:33:34 +0100 Original-Received: from localhost ([::1]:40074 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaYy4-0008Tr-Bu for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2012 16:33:24 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaYy1-0008TX-F6 for emacs-devel@gnu.org; Mon, 19 Nov 2012 16:33:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaYy0-0002ZN-G3 for emacs-devel@gnu.org; Mon, 19 Nov 2012 16:33:21 -0500 Original-Received: from stringer.orebokech.com ([88.190.240.207]:56173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaYxy-0002Yz-Dd; Mon, 19 Nov 2012 16:33:18 -0500 Original-Received: from silenus.orebokech.com (silenus [192.168.1.4]) by stringer.orebokech.com (Postfix) with ESMTP id 2CB621880207; Mon, 19 Nov 2012 22:33:17 +0100 (CET) Original-Received: by silenus.orebokech.com (Postfix, from userid 1000) id F3E37A02F4; Mon, 19 Nov 2012 22:33:16 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Mon, 19 Nov 2012 13:11:55 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 88.190.240.207 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154967 Archived-At: Hi everyone, Stefan Monnier writes: >> This is really a general comment, not an issue with your patch in >> particular, so don't let it distract. I just wonder if it is possible to >> find a different way to pass this information around, so that we don't >> need to have an ever increasing list of function arguments and return >> values (preserve-this, preserve-that, preserve-the-other, etc...). >> I don't have a good suggestion for how to do that. >> (I have a vague memory this was mentioned when SELinux was added.) > Yes, that's a problem. We should consolidate `modes', `context', and > `acl' into a `metadata' argument. Ok, in files.el I can refactor the code to pass all the metadata in one go and avoid the extra ACL argument here and there, no problem. However, I think Glenn was also referring to the additional argument to `copy-file', which doesn't preserve the modes. But maybe we can change the existing `preserve-selinux-context' argument into a more general `preserve-platform-attributes' argument and do both ACL and SELinux? Any caller that wants to preserve the SELinux context probably wants to preserve the ACL entries as well, anyway. Ideally we'd get rid of `file-modes', `file-selinux-context' and `file-posix-acl' and just add the info to `file-attributes', which already returns a list of 12 different attributes. Then `set-file-attributes' would be created to set all those different attributes in one go. But that would be a lot of work... Thanks!