From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards Date: Tue, 26 Mar 2013 10:21:08 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87ehf2utrf.fsf@lifelogs.com> References: Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364307700 12359 80.91.229.3 (26 Mar 2013 14:21:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Mar 2013 14:21:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 26 15:22:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKUlD-00051f-Ow for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2013 15:21:59 +0100 Original-Received: from localhost ([::1]:39251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKUkp-0006tl-Qk for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2013 10:21:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKUkm-0006tA-3D for emacs-devel@gnu.org; Tue, 26 Mar 2013 10:21:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKUkj-00072X-SW for emacs-devel@gnu.org; Tue, 26 Mar 2013 10:21:32 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:46309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKUkj-00070r-Ks for emacs-devel@gnu.org; Tue, 26 Mar 2013 10:21:29 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UKUl2-0004NY-PI for emacs-devel@gnu.org; Tue, 26 Mar 2013 15:21:48 +0100 Original-Received: from pool-72-93-31-86.bstnma.east.verizon.net ([72.93.31.86]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 26 Mar 2013 15:21:48 +0100 Original-Received: from tzz by pool-72-93-31-86.bstnma.east.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 26 Mar 2013 15:21:48 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 12 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: pool-72-93-31-86.bstnma.east.verizon.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:8+luXQV8jAuctvFwV2RbhQNtmQA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158218 Archived-At: On Mon, 25 Mar 2013 15:32:53 +0100 Andreas Schwab wrote: AS> Stefan Monnier writes: >> Backwards according to what? AS> According to common sense. My vote, FWIW, is to leave the original code alone. Some authors prefer to put the constant first. Respect their style, or explicitly forbid it, but please don't do drive-by style changes. Ted