From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards
Date: Tue, 26 Mar 2013 10:21:08 -0400 [thread overview]
Message-ID: <87ehf2utrf.fsf@lifelogs.com> (raw)
In-Reply-To: mvm1ub3h7my.fsf@hawking.suse.de
On Mon, 25 Mar 2013 15:32:53 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
AS> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Backwards according to what?
AS> According to common sense.
My vote, FWIW, is to leave the original code alone. Some authors prefer
to put the constant first. Respect their style, or explicitly forbid
it, but please don't do drive-by style changes.
Ted
next prev parent reply other threads:[~2013-03-26 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1UJknW-0004ja-JF@vcs.savannah.gnu.org>
2013-03-25 14:06 ` [Emacs-diffs] /srv/bzr/emacs/trunk r112126: Reorder conditions that are written backwards Stefan Monnier
2013-03-25 14:32 ` Andreas Schwab
2013-03-26 14:21 ` Ted Zlatanov [this message]
2013-03-25 15:38 René Kyllingstad
2013-03-25 15:49 ` Eli Zaretskii
2013-03-25 16:30 ` Paul Eggert
2013-03-26 13:56 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehf2utrf.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.