From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14637: recent viper-mode regression Date: Wed, 19 Jun 2013 23:53:07 +0300 Organization: JURTA Message-ID: <87ehbx7vog.fsf@mail.jurta.org> References: <87sj0hfyqc.fsf@rho.meyering.net> <87y5a7xj2m.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1371675969 15208 80.91.229.3 (19 Jun 2013 21:06:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Jun 2013 21:06:09 +0000 (UTC) Cc: 14637@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 19 23:06:09 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UpPZw-0004Vj-BZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2013 23:06:08 +0200 Original-Received: from localhost ([::1]:41781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPZv-0006z4-GW for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2013 17:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPZr-0006yP-QZ for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2013 17:06:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpPZq-0005f1-PK for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2013 17:06:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPZq-0005ex-NE for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2013 17:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UpPZq-0007E9-Ad for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2013 17:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2013 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14637-submit@debbugs.gnu.org id=B14637.137167590527667 (code B ref 14637); Wed, 19 Jun 2013 21:06:02 +0000 Original-Received: (at 14637) by debbugs.gnu.org; 19 Jun 2013 21:05:05 +0000 Original-Received: from localhost ([127.0.0.1]:56485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpPYu-0007CA-MD for submit@debbugs.gnu.org; Wed, 19 Jun 2013 17:05:05 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:54032 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpPYr-0007Bk-De for 14637@debbugs.gnu.org; Wed, 19 Jun 2013 17:05:02 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9C517258B9E91C; Wed, 19 Jun 2013 14:04:59 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 18 Jun 2013 20:28:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75369 Archived-At: >> Grepping for `shell-command-on-region' revealed the exhaustive list >> of the callers that are fixed now with this patch to set both args >> OUTPUT-BUFFER and REPLACE to the same value in unison: > > Do all the callers need to be fixed? Most of them? A minority only? > If it's not just a minority, then maybe the better fix is to revert > revno:112695 (or at least change it) so that existing code doesn't need > to be changed. I fixed all the callers that missed the required REPLACE arg: 5 were in vi mode, and 1 in mh-e. They are just a minority out of total 25 occurrences of `shell-command-on-region'.