* bug#15128: 24.3.50; python.el completion broken
@ 2013-08-19 0:44 Rasmus Pank Roulund
2013-09-02 13:15 ` fgallina
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Pank Roulund @ 2013-08-19 0:44 UTC (permalink / raw)
To: 15128
Hi,
With Christopher Schmidt's comint changes on 2013-08-08 python.el
completion breaks. To reproduce do
emacs -q
M-x run-python
x [TAB]
I've included a simple fix that may or may not be sufficient. Here's
the diff -c output
*** python.el 2013-08-19 02:13:21.822104349 +0200
--- python1.el 2013-08-19 02:13:52.323300415 +0200
***************
*** 2276,2283 ****
;; heuristic.
(with-current-buffer (process-buffer process)
(buffer-substring-no-properties
! (overlay-start comint-last-prompt-overlay)
! (overlay-end comint-last-prompt-overlay))))
(completion-context
;; Check whether a prompt matches a pdb string, an import
;; statement or just the standard prompt and use the
--- 2276,2283 ----
;; heuristic.
(with-current-buffer (process-buffer process)
(buffer-substring-no-properties
! (marker-position (car comint-last-prompt))
! (marker-position (cdr comint-last-prompt)))))
(completion-context
;; Check whether a prompt matches a pdb string, an import
;; statement or just the standard prompt and use the
Here's a changelog, if needed.
2013-08-19 Rasmus Pank Roulund <emacs@pank.eu>
* progmodes/python.el (python-shell-completion-get-completions):
Replace reference to comint-last-prompt-overlay with
comint-last-prompt.
Let me know if I did something wrong!
–Rasmus
In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.2)
of 2013-08-17 on pank
Bzr revision: eliz@gnu.org-20130817171807-fxigtkbc6yy8m9iw
Windowing system distributor `The X.Org Foundation', version 11.0.11402000
System Description: Arch Linux
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#15128: 24.3.50; python.el completion broken
2013-08-19 0:44 bug#15128: 24.3.50; python.el completion broken Rasmus Pank Roulund
@ 2013-09-02 13:15 ` fgallina
0 siblings, 0 replies; 2+ messages in thread
From: fgallina @ 2013-09-02 13:15 UTC (permalink / raw)
To: 15128-done
Hello Rasmus,
I fixed this in revno 114094. I took a different approach, avoiding use
of the comint-last-prompt* vars in a way to keep compatiblity with Emacs
24.x.
Regards,
Fabián.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-02 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-19 0:44 bug#15128: 24.3.50; python.el completion broken Rasmus Pank Roulund
2013-09-02 13:15 ` fgallina
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.