From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks Date: Sun, 24 Nov 2013 23:41:44 +0900 Message-ID: <87eh65rhef.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385307564 20676 80.91.229.3 (24 Nov 2013 15:39:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Nov 2013 15:39:24 +0000 (UTC) To: 15966@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 24 16:39:28 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VkbmS-0008Ey-FU for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Nov 2013 16:39:28 +0100 Original-Received: from localhost ([::1]:47578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkbmS-0004Zm-2q for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Nov 2013 10:39:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkbmF-0004MS-Gq for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 10:39:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkbm3-0001Jx-O8 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 10:39:15 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkbm3-0001Js-Kd for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 10:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vkbm3-0003XL-EU for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 10:39:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Nov 2013 15:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138530749513490 (code B ref -1); Sun, 24 Nov 2013 15:39:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Nov 2013 15:38:15 +0000 Original-Received: from localhost ([127.0.0.1]:42249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkblH-0003VP-2Y for submit@debbugs.gnu.org; Sun, 24 Nov 2013 10:38:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45085) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vkat6-00025J-70 for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:42:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkass-0002fE-K6 for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:42:10 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:51993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkass-0002fA-GJ for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:42:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkasm-0005Jd-GR for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:42:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkasg-0002dE-D0 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:41:56 -0500 Original-Received: from mx1.redhat.com ([209.132.183.28]:16554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkasg-0002cs-46 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:41:50 -0500 Original-Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAOEfnrK022496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 Nov 2013 09:41:49 -0500 Original-Received: from dhcp-193-97.nrt.redhat.com (ovpn-116-17.sin2.redhat.com [10.67.116.17]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAOEfj3s028532 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sun, 24 Nov 2013 09:41:48 -0500 User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sun, 24 Nov 2013 10:38:11 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80904 Archived-At: eww should ask "yes or no" when add current page to bookmarks, since only "b" key to add bookmarks is easy to mistake. (My bookmarklist has amazingly increased.) Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks --- lisp/net/eww.el | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 86e0977..6f09d86 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -964,14 +964,16 @@ The browser to used is specified by the `shr-external-browser' variable." (when (equal eww-current-url (plist-get bookmark :url)) (error "Already bookmarked"))) - (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) - (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) - (push (list :url eww-current-url - :title title - :time (current-time-string)) - eww-bookmarks)) - (eww-write-bookmarks) - (message "Bookmarked %s (%s)" eww-current-url eww-current-title)) + (if (y-or-n-p "add bookmark this page? ") + (progn + (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) + (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) + (push (list :url eww-current-url + :title title + :time (current-time-string)) + eww-bookmarks)) + (eww-write-bookmarks) + (message "Bookmarked %s (%s)" eww-current-url eww-current-title)))) (defun eww-write-bookmarks () (with-temp-file (expand-file-name "eww-bookmarks" user-emacs-directory) -- 1.8.3.1