From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16285: 24.3.50; [PATCH] shr: handle tag with blank error. Date: Sun, 05 Jan 2014 20:47:12 +0900 Message-ID: <87eh4m1whr.fsf@dhcp-193-97.nrt.redhat.com> References: <877ganst3f.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1388922496 20772 80.91.229.3 (5 Jan 2014 11:48:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jan 2014 11:48:16 +0000 (UTC) Cc: Kenjiro NAKAYAMA , 16285@debbugs.gnu.org To: Lars Magne Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 05 12:48:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VzmBo-0003xd-Gp for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 12:48:20 +0100 Original-Received: from localhost ([::1]:57541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzmBo-0007Hj-6H for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jan 2014 06:48:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzmBd-0007Cj-MY for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 06:48:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzmBW-0001hW-Tv for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 06:48:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzmBW-0001hN-QF for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 06:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VzmBW-00006w-3G for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 06:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2014 11:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 16285-submit@debbugs.gnu.org id=B16285.1388922462344 (code B ref 16285); Sun, 05 Jan 2014 11:48:01 +0000 Original-Received: (at 16285) by debbugs.gnu.org; 5 Jan 2014 11:47:42 +0000 Original-Received: from localhost ([127.0.0.1]:35376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzmB4-000054-TP for submit@debbugs.gnu.org; Sun, 05 Jan 2014 06:47:40 -0500 Original-Received: from mail-pa0-f54.google.com ([209.85.220.54]:47780) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzmAo-0008Vh-BE for 16285@debbugs.gnu.org; Sun, 05 Jan 2014 06:47:24 -0500 Original-Received: by mail-pa0-f54.google.com with SMTP id rd3so17523768pab.13 for <16285@debbugs.gnu.org>; Sun, 05 Jan 2014 03:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=5/1b8U/R4qnyCDOSPBsPWo61h6pbwtRjJ8LcRusXDOo=; b=BkUK6aM0R3XXQ1a0/0f+3WAN7Q2mnrNRGdi45hqDFTW3WOLT9j8AKdwwuy74T7peMB mJF1HKUESERNmCOEVPDzfi33BeaJ2zQh4i7XXXFKjh92/YIwhbAjrFrFOGIMMuWbmFCU h5OpQhN58o1xeB+R20lZQJIJaokxY/FAIEv6whKLgpPO8uuMTk76IcirJ4ZBLbG7dWDs fjBEHkL3R7x6kjYTamnlCf7AgRZfwK3mrFB4G7jOd/kMQKetQxTPLRJhuLpnCSSFP0Zd lBIpjlPp4wlebIpnLYu0+mcr8LkfJISJPop+E4hRj5XxDfL63Mcbp7owmLt0eBmmmZRb Gsjg== X-Received: by 10.68.87.98 with SMTP id w2mr50870497pbz.2.1388922437126; Sun, 05 Jan 2014 03:47:17 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id iu7sm121429681pbc.45.2014.01.05.03.47.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Jan 2014 03:47:16 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82996 Archived-At: > I've now fixed this in a different manner. Your patch would have bugged > out if the empty anchor was the first element in the buffer, so I just > made it insert a "*" if we have an empty anchor. Thanks! > The anchoring mechanism should perhaps be implemented in a different > way -- markers instead of text properties, for instance? That way The markers is good idea. Inserting "*" is not bad, but if it is possible, markers is good. Kenjiro larsi@gnus.org writes: > Kenjiro NAKAYAMA writes: > >> * net/eww.el (shr-descend): Handle tag with blank error. > > I've now fixed this in a different manner. Your patch would have bugged > out if the empty anchor was the first element in the buffer, so I just > made it insert a "*" if we have an empty anchor. > > The anchoring mechanism should perhaps be implemented in a different > way -- markers instead of text properties, for instance? That way > zero-length anchors would be no problem. Rewriting it in that way > should probably wait until after the feature freeze, though.