all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ian D <dunni@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: Doc View Page Problems
Date: Sat, 19 Apr 2014 23:10:02 -0400	[thread overview]
Message-ID: <87eh0selx1.fsf@gnu.org> (raw)
In-Reply-To: <jwvwqekracz.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 19 Apr 2014 22:47:58 -0400")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>        One more thing that I noticed is that image-mode itself doesn't
>>        setup the default window configuration, so I've included a patch
>>        that will do this.
>
> Not sure if that's the right way to do it.
> How 'bout the patch below instead?
>
>
>         Stefan
>
>
> === modified file 'lisp/image-mode.el'
> --- lisp/image-mode.el	2014-04-17 03:58:25 +0000
> +++ lisp/image-mode.el	2014-04-20 02:46:54 +0000
> @@ -90,9 +90,8 @@
>  
>  (defun image-mode-window-put (prop val &optional winprops)
>    (unless (consp winprops) (setq winprops (image-mode-winprops winprops)))
> -  (setcdr (assq t image-mode-winprops-alist)
> -          (cons (cons prop val)
> -                (delq (assq prop (cdr winprops)) (cdr winprops))))
> +  (unless (eq t (car winprops))
> +    (image-mode-window-put prop val t))
>    (setcdr winprops (cons (cons prop val)
>                           (delq (assq prop (cdr winprops)) (cdr winprops)))))
>  
>

        That seems to do the trick.  I say go for it.

Ian D



      reply	other threads:[~2014-04-20  3:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 13:24 Doc View Page Problems Ian D
2014-04-15 16:51 ` Stefan Monnier
2014-04-16 13:06   ` Ian D
2014-04-16 14:18     ` Stefan Monnier
2014-04-16 16:01       ` Ian D
2014-04-16 18:09         ` Stefan Monnier
2014-04-16 19:27           ` Ian D
2014-04-17  3:58             ` Stefan Monnier
2014-04-18 20:23             ` Ian D
2014-04-20  2:47               ` Stefan Monnier
2014-04-20  3:10                 ` Ian D [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eh0selx1.fsf@gnu.org \
    --to=dunni@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.