rcs2log

rcs2log

[Thomas Dickey]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Two bugs noted (patch attached):

	The script doesn't handle symbolic links to RCS directories.

	A bogus hostname is applied to userid's that are not found on
	the current system.

-- 
Thomas E. Dickey <dickey@invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net

[-- Attachment #2: rcs2log.diff --]
[-- Type: text/plain, Size: 1567 bytes --]

--- rcs2log	2003/04/25 20:16:12	1.1
+++ rcs2log	2003/04/26 14:47:00
@@ -31,6 +31,9 @@
 
 Id='$Id: rcs2log,v 1.50 2002/02/03 17:31:31 eggert Exp $'
 
+# modified to allow for symbolic links to RCS directories -T.Dickey
+# modified to avoid using bogus hostname for authors -T.Dickey
+
 # Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2001, 2002
 #  Free Software Foundation, Inc.
 
@@ -302,21 +305,21 @@
 			IFS=$nl
 			case $recursive in
 			t)
-				RCSdirs=`find . -name RCS -type d -print`
+				RCSdirs=`find . -name RCS -print`
 				filesFromRCSfiles='s|,v$||; s|/RCS/|/|; s|^\./||'
 				files=`
 					{
-						case $RCSdirs in
-						?*) find $RCSdirs \
-								-type f \
+					for dir in $RCSdirs
+					do
+						( cd $dir && \
+							find . -type f \
 								! -name '*_' \
 								! -name ',*,' \
 								! -name '.*_' \
 								! -name .rcsfreeze.log \
 								! -name .rcsfreeze.ver \
-								-print;;
-						esac
-						find . -name '*,v' -print
+								-print | sed -e 's|^\./|'$dir/'|' )
+					done
 					} |
 					sort -u |
 					sed "$filesFromRCSfiles"
@@ -699,11 +702,12 @@
 				auth = fullname[author]
 			else
 				auth = author
-			printf "%s%s  %s  ", date, zone, auth
+			printf "%s%s  %s", date, zone, auth
 			if (mailaddr[author])
-				printf "<%s>\n\n", mailaddr[author]
-			else
-				printf "<%s@%s>\n\n", author, "'"$hostname"'"
+				printf "  <%s>", mailaddr[author]
+			else if (fullname[author])
+				printf "  <%s@%s>", author, "'"$hostname"'"
+			printf "\n\n"
 		}
 		if (! filesknown[$1]) {
 			filesknown[$1] = 1

[-- Attachment #3: Type: text/plain, Size: 148 bytes --]

_______________________________________________
Bug-gnu-emacs mailing list
Bug-gnu-emacs@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs

rcs2log

[Glenn Morris]

Emacs's lib-src/rcs2log is semi-busted, as reported

http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg01107.html
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=427167

7 years ago.

Does Emacs really need to supply rcs2log, or can we simply let people
get it as part of the cvs package (e.g. both Debian and Red Hat provide
it with `cvs').

If the former, then the Emacs version needs to be fixed.
(The CVS one was years ago.)

Re: rcs2log

[Paul Eggert]

Glenn Morris wrote:
> Emacs's lib-src/rcs2log is semi-busted, as reported

News to me.  Thanks for reporting it; I installed a fix in emacs-24 bzr 
117129.

Re: rcs2log

[Stefan Monnier]

> Does Emacs really need to supply rcs2log, or can we simply let people
> get it as part of the cvs package (e.g. both Debian and Red Hat provide
> it with `cvs').

I'd expect any user of RCS/CVS to have rcs2log installed from elsewhere
already, indeed.
We could remove it from trunk and see if someone pays us enough to bring
it back.


        Stefan

Re: rcs2log

[Eric S. Raymond]

Stefan Monnier <monnier@IRO.UMontreal.CA>:
> > Does Emacs really need to supply rcs2log, or can we simply let people
> > get it as part of the cvs package (e.g. both Debian and Red Hat provide
> > it with `cvs').
> 
> I'd expect any user of RCS/CVS to have rcs2log installed from elsewhere
> already, indeed.
> We could remove it from trunk and see if someone pays us enough to bring
> it back.

+1

I believe I wrote this a very long time ago, like in 1991-1992, to go
with the earliest versions of VC mode.  It was just a workaround for a
report generator that should have existed in RCS at the time, there's
no real smarts in it.  If it can be replaced by something CVS ships,
it should be.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Re: rcs2log

[Paul Eggert]

Stefan Monnier wrote:
> I'd expect any user of RCS/CVS to have rcs2log installed

I wouldn't.  RCS doesn't ship it, and CVS is often installed without it. 
  For example, on Fedora 20 it's part of the cvs-contrib package, not 
the cvs package, and although I had CVS installed on my desktop I didn't 
have rcs2log in /usr/bin because I didn't have cvs-contrib.

Besides, the version in Emacs is the True Version of rcs2log; the 
version in cvs-contrib is a pale imitation (a ten-year-old fork without 
a lot of fixes that are in Emacs).

Perhaps rcs2log should be moved to RCS or to CVS or both, but unless and 
until it's reliably in its destination(s) Emacs should keep it around.

Eric S. Raymond wrote:

> I believe I wrote this a very long time ago

No, we can't pin this one on you.  I wrote it.

Re: rcs2log

[Eric S. Raymond]

Paul Eggert <eggert@cs.ucla.edu>:
> >I believe I wrote this a very long time ago
> 
> No, we can't pin this one on you.  I wrote it.

Looks like you did, yes.

I have dim memories of writing something like this as a VC-mode helper 
for either RCS or SCCS, in order to drastically cut the complexity of the
Lisp in the mode.  I guess whatever that was got plowed under long ago.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Re: rcs2log

[David Kastrup]

Paul Eggert <eggert@cs.ucla.edu> writes:

> Eric S. Raymond wrote:
>
>> I believe I wrote this a very long time ago
>
> No, we can't pin this one on you.  I wrote it.

I am Spartacus.

-- 
David Kastrup

Re: rcs2log

[Stephen Berman]

On Tue, 20 May 2014 17:43:51 +0200 David Kastrup <dak@gnu.org> wrote:

> Paul Eggert <eggert@cs.ucla.edu> writes:
>
>> Eric S. Raymond wrote:
>>
>>> I believe I wrote this a very long time ago
>>
>> No, we can't pin this one on you.  I wrote it.
>
> I am Spartacus.

I'm Brian!

Re: rcs2log

[Glenn Morris]

Thanks for the speedy fixes.
Maybe contact help-rcs@gnu.org about getting it into RCS?
The Emacs version installs into libexec/, so is not even in the PATH
outside Emacs. It doesn't seem to do anything that is specific to Emacs.

Re: rcs2log

[Stephen J. Turnbull]

Stephen Berman writes:
 > On Tue, 20 May 2014 17:43:51 +0200 David Kastrup <dak@gnu.org> wrote:
 > 
 > > Paul Eggert <eggert@cs.ucla.edu> writes:
 > >
 > >> Eric S. Raymond wrote:
 > >>
 > >>> I believe I wrote this a very long time ago
 > >>
 > >> No, we can't pin this one on you.  I wrote it.
 > >
 > > I am Spartacus.
 > 
 > I'm Brian!

Since when is this a Python list?