* bug#18599: erc-input-ring-setup: do not reset the ring when there already is one
[not found] <CAPQGGprdT3C91p=704sJc2FpgPNWy7saTDJC9a2WLb8v71q5UQ@mail.gmail.com>
@ 2014-10-02 5:11 ` Ivan Shmakov
2014-11-21 19:31 ` Ivan Shmakov
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Shmakov @ 2014-10-02 5:11 UTC (permalink / raw
To: 18599; +Cc: erc-discuss, kashish sharma
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
Package: emacs
X-Debbugs-Cc: erc-discuss@gnu.org, Kashish Sharma <music.kashish@gmail.com>
>>>>> Kashish Sharma <music.kashish@gmail.com> writes:
[…]
> 2. (what seems like another bug -) Input history is lost if one
> disconnects/reconnects.
Please consider the patch MIMEd.
(This one was also recently pointed out on IRC, BTW.)
> Wishlist - input history remembered across Emacs sessions. Perhaps
> with the option of setting the history size.
[…]
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 452 bytes --]
--- a/lisp/erc/erc-ring.el
+++ b/lisp/erc/erc-ring.el
@@ -67,7 +67,8 @@
(defun erc-input-ring-setup ()
"Do the setup required so that we can use comint style input rings.
Call this function when setting up the mode."
- (setq erc-input-ring (make-ring comint-input-ring-size))
+ (unless (ring-p erc-input-ring)
+ (setq erc-input-ring (make-ring comint-input-ring-size)))
(setq erc-input-ring-index nil))
(defun erc-add-to-input-ring (s)
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#18599: erc-input-ring-setup: do not reset the ring when there already is one
2014-10-02 5:11 ` bug#18599: erc-input-ring-setup: do not reset the ring when there already is one Ivan Shmakov
@ 2014-11-21 19:31 ` Ivan Shmakov
0 siblings, 0 replies; 2+ messages in thread
From: Ivan Shmakov @ 2014-11-21 19:31 UTC (permalink / raw
To: 18599-done; +Cc: erc-discuss
Version: 24.5
I no longer observe the issue (as of 2014-11-18 build,
cb4f666ade76.) Per my reading of the Git log, it was fixed in
Git master back this October:
commit 3af2917c91e4eb863e1cec92a68ccb3acf940dae
Author: Ivan Shmakov <ivan@siamics.net>
AuthorDate: Thu Oct 2 07:31:56 2014 -0400
Commit: Kelvin White <kwhite@gnu.org>
CommitDate: Thu Oct 2 07:31:56 2014 -0400
Do not reset input ring if one exists
Fixes: debbugs:18599
In emacs-24, this bug was fixed as part of the following
“backport” change:
commit d1036d288de1e047f7f6043188a1063f0d6b044d
Author: l3thal <l3thal@debian>
AuthorDate: Sat Nov 8 20:51:43 2014 -0500
Commit: l3thal <l3thal@debian>
CommitDate: Sat Nov 8 20:51:43 2014 -0500
backport: erc bugfixes
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-21 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAPQGGprdT3C91p=704sJc2FpgPNWy7saTDJC9a2WLb8v71q5UQ@mail.gmail.com>
2014-10-02 5:11 ` bug#18599: erc-input-ring-setup: do not reset the ring when there already is one Ivan Shmakov
2014-11-21 19:31 ` Ivan Shmakov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.