From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#18599: erc-input-ring-setup: do not reset the ring when there already is one Date: Thu, 02 Oct 2014 05:11:03 +0000 Message-ID: <87egurf448.fsf@violet.siamics.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1412226751 2974 80.91.229.3 (2 Oct 2014 05:12:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 2 Oct 2014 05:12:31 +0000 (UTC) Cc: erc-discuss@gnu.org, kashish sharma To: 18599@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 02 07:12:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XZYgi-0008Q1-0E for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Oct 2014 07:12:24 +0200 Original-Received: from localhost ([::1]:60124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZYgh-0003PB-GW for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Oct 2014 01:12:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZYgZ-0003Or-Sk for bug-gnu-emacs@gnu.org; Thu, 02 Oct 2014 01:12:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZYgV-0006ly-Nk for bug-gnu-emacs@gnu.org; Thu, 02 Oct 2014 01:12:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZYgM-0006jJ-S2; Thu, 02 Oct 2014 01:12:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XZYgL-0001QS-Sj; Thu, 02 Oct 2014 01:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: erc-discuss@gnu.org, music.kashish@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Oct 2014 05:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: submit@debbugs.gnu.org X-Debbugs-Original-Xcc: erc-discuss@gnu.org, kashish sharma Original-Received: via spool by submit@debbugs.gnu.org id=B.14122266785414 (code B ref -1); Thu, 02 Oct 2014 05:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Oct 2014 05:11:18 +0000 Original-Received: from localhost ([127.0.0.1]:57949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XZYfd-0001PE-O4 for submit@debbugs.gnu.org; Thu, 02 Oct 2014 01:11:18 -0400 Original-Received: from fely.am-1.org ([78.47.74.50]:34862) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XZYfa-0001P3-Ox for submit@debbugs.gnu.org; Thu, 02 Oct 2014 01:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=t0N/uWIZd/YQixpgWDYSAX7VAKupaQ5EbO+EFjwa0oY=; b=iXMiwnQogSUPjQZnG85LZTrrR9+0lpwXpLrJBlGo85EgPjHE5spZyOb5HmT/jqojKhu/Gf1Z7xG4M5z97YNP50kSTNuRN1dHiiGviFgNB50YuIILTH6J9E6N+sQT/2UFKsq+F5r98Mdtw4LDA8uW+kHy7fSn6ADWZ7Gdl4ieaqM=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XZYfY-0004tV-F6 for submit@debbugs.gnu.org; Thu, 02 Oct 2014 05:11:12 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XZYfQ-0000Od-3M for submit@debbugs.gnu.org; Thu, 02 Oct 2014 12:11:04 +0700 In-Reply-To: (Kashish Sharma's message of "Thu, 2 Oct 2014 02:23:54 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94009 gmane.emacs.erc.general:1381 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs X-Debbugs-Cc: erc-discuss@gnu.org, Kashish Sharma >>>>> Kashish Sharma writes: [=E2=80=A6] > 2. (what seems like another bug -) Input history is lost if one > disconnects/reconnects. Please consider the patch MIMEd. (This one was also recently pointed out on IRC, BTW.) > Wishlist - input history remembered across Emacs sessions. Perhaps > with the option of setting the history size. [=E2=80=A6] --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/erc/erc-ring.el +++ b/lisp/erc/erc-ring.el @@ -67,7 +67,8 @@ (defun erc-input-ring-setup () "Do the setup required so that we can use comint style input rings. Call this function when setting up the mode." - (setq erc-input-ring (make-ring comint-input-ring-size)) + (unless (ring-p erc-input-ring) + (setq erc-input-ring (make-ring comint-input-ring-size))) (setq erc-input-ring-index nil)) (defun erc-add-to-input-ring (s) --=-=-=--