all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ivan Shmakov <ivan@siamics.net>
To: 18599@debbugs.gnu.org
Cc: erc-discuss@gnu.org, kashish sharma <music.kashish@gmail.com>
Subject: bug#18599: erc-input-ring-setup: do not reset the ring when there already is one
Date: Thu, 02 Oct 2014 05:11:03 +0000	[thread overview]
Message-ID: <87egurf448.fsf@violet.siamics.net> (raw)
In-Reply-To: <CAPQGGprdT3C91p=704sJc2FpgPNWy7saTDJC9a2WLb8v71q5UQ@mail.gmail.com> (Kashish Sharma's message of "Thu, 2 Oct 2014 02:23:54 +0530")

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Package: emacs
X-Debbugs-Cc: erc-discuss@gnu.org, Kashish Sharma <music.kashish@gmail.com>

>>>>> Kashish Sharma <music.kashish@gmail.com> writes:

[…]

 > 2. (what seems like another bug -) Input history is lost if one
 > disconnects/reconnects.

	Please consider the patch MIMEd.

	(This one was also recently pointed out on IRC, BTW.)

 > Wishlist - input history remembered across Emacs sessions.  Perhaps
 > with the option of setting the history size.

[…]

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/diff, Size: 452 bytes --]

--- a/lisp/erc/erc-ring.el
+++ b/lisp/erc/erc-ring.el
@@ -67,7 +67,8 @@
 (defun erc-input-ring-setup ()
   "Do the setup required so that we can use comint style input rings.
 Call this function when setting up the mode."
-  (setq erc-input-ring (make-ring comint-input-ring-size))
+  (unless (ring-p erc-input-ring)
+    (setq erc-input-ring (make-ring comint-input-ring-size)))
   (setq erc-input-ring-index nil))
 
 (defun erc-add-to-input-ring (s)

       reply	other threads:[~2014-10-02  5:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAPQGGprdT3C91p=704sJc2FpgPNWy7saTDJC9a2WLb8v71q5UQ@mail.gmail.com>
2014-10-02  5:11 ` Ivan Shmakov [this message]
2014-11-21 19:31   ` bug#18599: erc-input-ring-setup: do not reset the ring when there already is one Ivan Shmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egurf448.fsf@violet.siamics.net \
    --to=ivan@siamics.net \
    --cc=18599@debbugs.gnu.org \
    --cc=erc-discuss@gnu.org \
    --cc=music.kashish@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.