all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Cc: Vibhav Pant <vibhavp@gmail.com>
Subject: Re: [PATCH][BUG]: eww doesnt trim whitespace from address
Date: Mon, 03 Nov 2014 08:46:45 -0500	[thread overview]
Message-ID: <87egtkbdmi.fsf@lifelogs.com> (raw)
In-Reply-To: CA+T2Sh1dq-F0eEpcMgUvC7nPZSF7eAV5zf4QzgwqnBpBop=Kgw@mail.gmail.com

On Fri, 21 Mar 2014 14:57:37 +0530 Vibhav Pant <vibhavp@gmail.com> wrote: 

VP> As of now, eww does not rim the user specified address, this often
VP> leads to problems especially if the address is from the clipboard (eww
VP> reports that the service isnt known). Most browsers automatically do
VP> this, so I have included a patch to solve this problem.

VP> This patch simply setq's url to a "trimmed" version of it.
VP> The change is pretty non trivial, so I think it can be included in this release.

I think the fairly recent function `string-trim' would be better than
the proposed regex approach.

I also don't know if there are any exceptions to this--are there cases
where you want to preserve the trailing space on a URL and/or encode
them to "%20"?

Thanks
Ted




  reply	other threads:[~2014-11-03 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21  9:27 [PATCH][BUG]: eww doesnt trim whitespace from address Vibhav Pant
2014-11-03 13:46 ` Ted Zlatanov [this message]
2014-11-03 14:49   ` Yuri Khan
2014-11-04 16:33     ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egtkbdmi.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=emacs-devel@gnu.org \
    --cc=vibhavp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.