From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19170: 25.0.50; enhancement request: `compare-windows' use across frames Date: Tue, 25 Nov 2014 00:19:32 +0200 Organization: LINKOV.NET Message-ID: <87egss9r7v.fsf@mail.linkov.net> References: <32848088-e8db-46dc-b9c7-f53bc46bb4e1@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416870268 19217 80.91.229.3 (24 Nov 2014 23:04:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Nov 2014 23:04:28 +0000 (UTC) Cc: 19170@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 25 00:04:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xt2g6-0006th-2V for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Nov 2014 00:04:18 +0100 Original-Received: from localhost ([::1]:54818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2g5-0000nV-M4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Nov 2014 18:04:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2fx-0000nN-4b for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2014 18:04:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xt2fq-00070q-WC for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2014 18:04:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xt2fq-00070m-Sz for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2014 18:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xt2fq-0006Fi-97 for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2014 18:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Nov 2014 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19170-submit@debbugs.gnu.org id=B19170.141687019423907 (code B ref 19170); Mon, 24 Nov 2014 23:04:02 +0000 Original-Received: (at 19170) by debbugs.gnu.org; 24 Nov 2014 23:03:14 +0000 Original-Received: from localhost ([127.0.0.1]:44352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xt2f3-0006DU-IR for submit@debbugs.gnu.org; Mon, 24 Nov 2014 18:03:14 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.222.226]:57001 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xt1z8-0004CE-AX for 19170@debbugs.gnu.org; Mon, 24 Nov 2014 17:19:54 -0500 Original-Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id E5F23348328E6C; Mon, 24 Nov 2014 14:19:53 -0800 (PST) In-Reply-To: <32848088-e8db-46dc-b9c7-f53bc46bb4e1@default> (Drew Adams's message of "Mon, 24 Nov 2014 11:24:26 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-Mailman-Approved-At: Mon, 24 Nov 2014 18:03:12 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96525 Archived-At: > (None of the current behavior should be lost, in particular, behavior > per `compare-windows-sync'.) Thanks for the bug report. The patch below fixes it in `compare-windows-sync' to use the same frame-selecting logic like existed for a long time in `compare-windows': diff --git a/lisp/vc/compare-w.el b/lisp/vc/compare-w.el index 25d4cf7..26f8be4 100644 --- a/lisp/vc/compare-w.el +++ b/lisp/vc/compare-w.el @@ -304,6 +304,9 @@ on third call it again advances points to the next difference and so on." (if (not compare-windows-sync-point) (let* ((w1 (selected-window)) (w2 (next-window w1)) + (w2 (if (eq w2 (selected-window)) + (next-window (selected-window) nil 'visible) + w2)) (b2 (window-buffer w2)) (point-max2 (with-current-buffer b2 (point-max))) (op2 (window-point w2))