Re: master d20acfe: Fix Gnus registry pruning and sorting, and rename file

[Eric Abrahamsen <eric@ericabrahamsen.net>]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Hi!
>
>> branch: master
>> commit d20acfe06340953dce443795d28ac224a2223414
>> Author: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Commit: Katsumi Yamaoka <yamaoka@jpl.org>
>
> This commit breaks compilation of Emacs master:

I just got a bunch of mean emails from the buildbot...

Sorry about that. I didn't know enough about the build process to
anticipate this failure -- I guess most-positive-fixnum isn't available
when batch-compiling?

I've attached a patch that puts things back the way they were.

Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Revert-gnus-registry-slot-initform-to-previous-value.patch --]
[-- Type: text/x-diff, Size: 921 bytes --]

From c556f9b91e9a1d2d0fefb7440d49d09ba375b0fa Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Thu, 18 Dec 2014 23:22:43 +0800
Subject: [PATCH] Revert gnus registry slot initform to previous value

* lisp/gnus/registry.el (registry-db): Hardcode an integer; using
  most-positive-fixnum breaks compilation.
---
 lisp/gnus/registry.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/gnus/registry.el b/lisp/gnus/registry.el
index d086d64..bd711e7 100644
--- a/lisp/gnus/registry.el
+++ b/lisp/gnus/registry.el
@@ -98,7 +98,7 @@
             :type (or null float)
             :documentation "The registry version.")
    (max-size :initarg :max-size
-             :initform most-positive-fixnum
+             :initform 5000000
              :type integer
              :custom integer
              :documentation "The maximum number of registry entries.")
-- 
2.2.0


[-- Attachment #3: Type: text/plain, Size: 649 bytes --]



> Compiling gnus/gnus-registry.el
> Eager macro-expansion failure: (invalid-slot-type max-size integer most-positive-fixnum)
> Eager macro-expansion failure: (invalid-slot-type max-size integer most-positive-fixnum)
>
> In toplevel form:
> gnus/gnus-registry.el:88:1:Error: Invalid slot type: max-size, integer, most-positive-fixnum
> make[3]: *** [gnus/gnus-registry.elc] Error 1
> make[3]: Leaving directory `/home/gutov/vc/emacs/lisp'
> make[2]: *** [compile-main] Error 2
> make[2]: Leaving directory `/home/gutov/vc/emacs/lisp'
> make[1]: *** [lisp] Error 2
> make[1]: Leaving directory `/home/gutov/vc/emacs'
> make: *** [bootstrap] Error 2