From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Artur Malabarba <bruce.connor.am@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: package.el dependencies
Date: Mon, 02 Feb 2015 21:35:29 +0100 [thread overview]
Message-ID: <87egq83veh.fsf@gmail.com> (raw)
In-Reply-To: <jwvy4oggva5.fsf-monnier+emacs@gnu.org> <emacs-devel@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> We have a problem: since package-reinstall does a `package-delete'
> and since this `package-delete' always marks the package as unselected,
> it follows that package-reinstall will always mark the package as
> unselected :-(
This patch fix this issue:
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 9a29d63..296ee46 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1239,7 +1239,8 @@ to `package-selected-packages'."
"Reinstall package: "
(mapcar #'symbol-name
(mapcar #'car package-alist))))))
- (package-delete (cadr (assq pkg package-alist)) t)
+ (package-delete (cadr (assq pkg package-alist)) 'force
+ (memq pkg package-selected-packages))
(package-install pkg))
(defun package-strip-rcs-id (str)
@@ -1470,7 +1471,7 @@ with PKG-DESC entry removed."
(and (memq pkg (mapcar #'car (package-desc-reqs (cadr p))))
(car p))))))
-(defun package-delete (pkg-desc &optional force)
+(defun package-delete (pkg-desc &optional force nosave)
"Delete package PKG-DESC.
Argument PKG-DESC is a full description of package as vector.
@@ -1506,7 +1507,8 @@ elsewhere."
(unless (cdr pkgs)
(setq package-alist (delq pkgs package-alist))))
;; Update package-selected-packages.
- (when (memq name package-selected-packages)
+ (when (and (memq name package-selected-packages)
+ (null nosave))
(customize-save-variable
'package-selected-packages (remove name package-selected-packages)))
(message "Package `%s' deleted." (package-desc-full-name pkg-desc))))))
> One more thing: now that we have package-selected-packages,
> package-delete should be fixed to be a real "inverse" of
> package-install, i.e. it should delete its unused dependencies.
Hmm, not sure it is a good idea.
> One more thing: it'd be great to extend the list-package display so as
> to indicate which packages are selected and which ones aren't.
I already did this in helm, with "I" in first column, but in helm the
first 2 columns are not needed like in list-package ("I" and "D").
Will see what I can do even if I don't use this UI.
Will look in next issues tomorrow.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2015-02-02 20:35 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 13:37 package.el dependencies Thierry Volpiatto
2015-01-23 13:46 ` Dmitry Gutov
2015-01-23 14:12 ` Ivan Shmakov
2015-01-23 20:40 ` Stefan Monnier
2015-01-23 21:02 ` Thierry Volpiatto
2015-01-24 0:50 ` Artur Malabarba
2015-01-24 4:55 ` Stefan Monnier
2015-01-25 6:51 ` Thierry Volpiatto
2015-01-26 7:17 ` Thierry Volpiatto
2015-01-26 9:19 ` Artur Malabarba
2015-01-26 9:54 ` Thierry Volpiatto
2015-01-26 12:46 ` Artur Malabarba
2015-01-26 14:52 ` Stefan Monnier
2015-01-27 6:10 ` Thierry Volpiatto
2015-01-27 11:52 ` Artur Malabarba
2015-01-25 9:18 ` Thierry Volpiatto
2015-01-25 14:54 ` Stefan Monnier
2015-01-25 15:48 ` Thierry Volpiatto
2015-01-25 17:10 ` Dmitry Gutov
2015-01-25 18:32 ` Stephen Leake
2015-01-25 18:21 ` Artur Malabarba
2015-01-26 4:48 ` Thierry Volpiatto
2015-01-26 12:35 ` Artur Malabarba
2015-01-26 12:53 ` Artur Malabarba
2015-01-26 15:22 ` Thierry Volpiatto
2015-01-26 15:44 ` Stefan Monnier
2015-01-27 6:08 ` Thierry Volpiatto
2015-01-26 16:34 ` Artur Malabarba
2015-01-28 7:30 ` Thierry Volpiatto
2015-01-28 8:55 ` Thierry Volpiatto
2015-01-28 12:42 ` Thierry Volpiatto
2015-01-28 13:17 ` Artur Malabarba
2015-01-28 14:32 ` Thierry Volpiatto
2015-01-28 13:40 ` Dmitry Gutov
2015-01-28 10:47 ` Artur Malabarba
2015-01-28 11:58 ` Thierry Volpiatto
2015-01-28 19:33 ` Stefan Monnier
2015-01-28 19:50 ` Ivan Shmakov
2015-01-28 20:12 ` Artur Malabarba
2015-01-28 22:20 ` Stefan Monnier
2015-01-29 5:31 ` Thierry Volpiatto
2015-01-29 7:22 ` Thierry Volpiatto
2015-01-30 5:38 ` Thierry Volpiatto
2015-01-30 16:43 ` Artur Malabarba
2015-01-30 17:13 ` Thierry Volpiatto
2015-01-31 6:01 ` Thierry Volpiatto
2015-01-31 10:58 ` Artur Malabarba
2015-01-31 20:26 ` Stefan Monnier
[not found] ` <874mr67gjb.fsf@gmail.com>
[not found] ` <jwvvbjmnun4.fsf-monnier+emacs@gnu.org>
[not found] ` <87oapervqv.fsf@gmail.com>
[not found] ` <jwvk302nnmd.fsf-monnier+emacs@gnu.org>
[not found] ` <877fw2kp1y.fsf@gmail.com>
[not found] ` <jwvioflbrlg.fsf-monnier+emacs@gnu.org>
[not found] ` <87d25tps2q.fsf@gmail.com>
[not found] ` <jwvy4oggva5.fsf-monnier+emacs@gnu.org>
2015-02-02 20:35 ` Thierry Volpiatto [this message]
2015-02-02 21:37 ` Artur Malabarba
2015-02-03 4:53 ` Thierry Volpiatto
2015-02-03 5:13 ` Stefan Monnier
2015-02-03 10:04 ` Artur Malabarba
2015-02-03 14:06 ` Artur Malabarba
2015-02-03 5:45 ` Thierry Volpiatto
2015-02-03 10:05 ` Artur Malabarba
2015-02-03 10:18 ` Thierry Volpiatto
2015-02-03 11:39 ` Artur Malabarba
2015-02-02 21:19 ` Thierry Volpiatto
2015-02-02 21:22 ` Dmitry Gutov
2015-02-03 11:39 ` Artur Malabarba
2015-02-03 11:44 ` Dmitry Gutov
2015-01-31 6:51 ` Thierry Volpiatto
2015-01-31 20:30 ` Stefan Monnier
2015-01-31 22:10 ` Thierry Volpiatto
2015-01-31 23:26 ` Artur Malabarba
2015-02-01 6:29 ` Thierry Volpiatto
2015-02-01 7:02 ` Thierry Volpiatto
2015-02-01 15:55 ` Thierry Volpiatto
2015-02-01 23:47 ` Artur Malabarba
2015-02-02 12:00 ` Artur Malabarba
2015-02-02 13:14 ` Thierry Volpiatto
2015-02-02 14:14 ` Thierry Volpiatto
2015-02-02 14:56 ` Artur Malabarba
2015-02-02 15:19 ` Thierry Volpiatto
2015-02-02 15:33 ` Thierry Volpiatto
2015-02-02 15:50 ` Artur Malabarba
2015-02-02 16:07 ` Thierry Volpiatto
2015-02-02 21:23 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egq83veh.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.