From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v1] Let input queue deal gracefully with up-events Date: Thu, 05 Feb 2015 18:23:36 +0100 Message-ID: <87egq4z2zr.fsf@fencepost.gnu.org> References: <20150128145849.GA5107@acm.acm> <1422458343-12633-1-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423157025 24684 80.91.229.3 (5 Feb 2015 17:23:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 17:23:45 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 18:23:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJQ9Y-00026e-NR for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 18:23:44 +0100 Original-Received: from localhost ([::1]:43418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQ9X-0005kh-V5 for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 12:23:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQ9U-0005iK-2A for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:23:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJQ9S-0006yA-Tr for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:23:39 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQ9S-0006y6-Rj for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:23:38 -0500 Original-Received: from localhost ([127.0.0.1]:58557 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQ9R-0002r0-Ie for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:23:38 -0500 Original-Received: by lola (Postfix, from userid 1000) id 031DCE6B62; Thu, 5 Feb 2015 18:23:36 +0100 (CET) In-Reply-To: <1422458343-12633-1-git-send-email-dak@gnu.org> (David Kastrup's message of "Wed, 28 Jan 2015 16:19:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182462 Archived-At: David Kastrup writes: > * keyboard.c (apply_modifiers_uncached, parse_solitary_modifier) > (parse_modifiers_uncached): React gracefully to "up-" modifiers: > those may easily be injected by user-level Lisp code. > (read_key_sequence): Discard unbound up-events like unbound > down-events: they are even more likely only relevant for special > purposes. > > While Emacs will not produce up-events on its own currently (those are > converted to drag or click events before being converted to > Lisp-readable structures), the input queue can be made to contain them > by synthesizing events to `unread-command-events'. This patch makes > Emacs deal consistently with such events. I've created bug report . Judging from the number of wishlist items in the tracker including a patch, that does not appear to increase its chances of getting applied but at least it is then rotting in the proper place. -- David Kastrup