From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files Date: Wed, 21 Oct 2015 17:04:13 +0200 Message-ID: <87eggoxnyq.fsf@gmail.com> References: <20151013135354.28594.43074@vcs.savannah.gnu.org> <87io69opbs.fsf@gmail.com> <83bnc083k3.fsf@gnu.org> <871tcvks7o.fsf@gmail.com> <83si5b54m9.fsf@gnu.org> <87wpunsz6w.fsf@gmail.com> <83mvvi6fu9.fsf@gnu.org> <87wpuhud8l.fsf@gmail.com> <83r3kpfuzw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445439885 3260 80.91.229.3 (21 Oct 2015 15:04:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2015 15:04:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 17:04:44 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZouwT-0002HM-QP for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 17:04:41 +0200 Original-Received: from localhost ([::1]:52022 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZouwT-0005tl-Al for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 11:04:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zouvc-00054I-Sy for emacs-devel@gnu.org; Wed, 21 Oct 2015 11:03:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZouvZ-0001Jl-2O for emacs-devel@gnu.org; Wed, 21 Oct 2015 11:03:48 -0400 Original-Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:36128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZouvY-0001Jf-TJ; Wed, 21 Oct 2015 11:03:45 -0400 Original-Received: by wicfx6 with SMTP id fx6so95662937wic.1; Wed, 21 Oct 2015 08:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=6vXuYgjFo55g5lRmrtzgW+8GhwqJO4CYQDLXIC6QJjM=; b=cThPx4gnawaK2o8JkKDpNW6VfXTVdB9gTQDGyIXkJ5zd2sXNpwGlNmbbHRueKFYQSp IsutDkEcx8EYmy6m8N7F5PKacV0OmcAqGlBczIRpxCDYET/fBP5P2SbeftTDgKzltpzb ZGRiQHpjRnjKljG13VcOj8H4e+C5eYYQjzf8DPYWYIe0PvCeqHZzTOpe52eyqUBYjIRo 6Reb8UBLK04xxZ//9wOhEpdx3jIXFmjPAuF47G24irj2Nyvf9BHXq5Skqlt3flMQ3BGb 7pbiAxlw4HymxLxCXU3cenwTLKBRD/XIATBrCcCAmxhnrCJnIBovFUhdtBldFoyrZVbZ pkcA== X-Received: by 10.180.189.102 with SMTP id gh6mr32336878wic.95.1445439823992; Wed, 21 Oct 2015 08:03:43 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by smtp.gmail.com with ESMTPSA id bv2sm10943772wjc.11.2015.10.21.08.03.42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 21 Oct 2015 08:03:43 -0700 (PDT) In-Reply-To: <83r3kpfuzw.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Oct 2015 17:57:23 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192289 Archived-At: Eli Zaretskii writes: >> (define-key map "c" 'dired-compress) >> >> The proposed key isn't bound by default. Is that OK? > > Sounds OK to me, but maybe wait for a while for others to speak up. I've committed this new command, turns out `dired-compress' was already taken: (define-key map "c" 'dired-do-compress-to) Please check if I didn't end up doing something strange. A few points: 1. Is using `cl-find-if' OK in dired.el (I assume this should be fine). 2. There's some autoload regeneration rule that modifies dired.el when dired-aux.el is modified. Should that autoload be committed together with a change? 3. Other recipes can be added to `dired-compress-files-alist'. I just added the two that I'm familiar with. It also needs to be checked if "zip" typically supports --filesync. 4. I've added NEWS entries, but I forgot how the +++/---/ markers work. Where is that info? I can document the changes in the manual once we agree that the change is fine.