all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleh Krehel <ohwoeowho@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files
Date: Wed, 21 Oct 2015 17:04:13 +0200	[thread overview]
Message-ID: <87eggoxnyq.fsf@gmail.com> (raw)
In-Reply-To: <83r3kpfuzw.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Oct 2015 17:57:23 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>>     (define-key map "c" 'dired-compress)
>> 
>> The proposed key isn't bound by default. Is that OK?
>
> Sounds OK to me, but maybe wait for a while for others to speak up.

I've committed this new command, turns out `dired-compress' was already
taken:

    (define-key map "c" 'dired-do-compress-to)

Please check if I didn't end up doing something strange. A few points:

1. Is using `cl-find-if' OK in dired.el (I assume this should be fine).

2. There's some autoload regeneration rule that modifies dired.el when
dired-aux.el is modified. Should that autoload be committed together
with a change?

3. Other recipes can be added to `dired-compress-files-alist'. I just
added the two that I'm familiar with. It also needs to be checked if
"zip" typically supports --filesync.

4. I've added NEWS entries, but I forgot how the +++/---/ markers
work. Where is that info? I can document the changes in the manual once
we agree that the change is fine.



  parent reply	other threads:[~2015-10-21 15:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151013135354.28594.43074@vcs.savannah.gnu.org>
     [not found] ` <E1Zm01b-0007SW-BB@vcs.savannah.gnu.org>
2015-10-13 18:28   ` master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files Glenn Morris
2015-10-13 18:38     ` Paul Eggert
2015-10-14  7:58       ` Oleh Krehel
2015-10-14 15:17         ` Paul Eggert
2015-10-14  7:56     ` Oleh Krehel
2015-10-14 16:16       ` Eli Zaretskii
2015-10-14 18:51         ` Achim Gratz
2015-10-14 19:02           ` Eli Zaretskii
2015-10-15 13:07           ` Oleh Krehel
2015-10-15 15:55             ` Eli Zaretskii
2015-10-15 19:46             ` Achim Gratz
2015-10-15 16:48       ` Glenn Morris
2015-10-15 17:06         ` Eli Zaretskii
2015-10-16 10:44           ` Oleh Krehel
2015-10-16 13:23             ` Eli Zaretskii
2015-10-16 13:47               ` Oleh Krehel
2015-10-16 14:35                 ` Eli Zaretskii
2015-10-20  8:59                   ` Oleh Krehel
2015-10-20 14:57                     ` Eli Zaretskii
2015-10-21  7:57                       ` Oleh Krehel
2015-10-21 15:04                       ` Oleh Krehel [this message]
2015-10-21 16:28                         ` Eli Zaretskii
2015-10-22 10:59                           ` Oleh Krehel
2015-10-20 22:51                     ` Juri Linkov
2015-10-21  8:00                       ` Oleh Krehel
2015-10-16 15:35               ` Paul Eggert
2015-10-16 16:11                 ` Eli Zaretskii
2015-10-16 16:26             ` Glenn Morris
2015-10-16 12:11         ` Oleh Krehel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eggoxnyq.fsf@gmail.com \
    --to=ohwoeowho@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.