From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Emanuel Berg <embe8573@student.uu.se>
Newsgroups: gmane.emacs.help
Subject: Re: writing ledger mode, date picker
Date: Tue, 10 Nov 2015 02:22:05 +0100
Message-ID: <87egfywsw2.fsf@debian.uxu>
References: <87r3k1362v.fsf@gmail.com> <87pozjrat7.fsf@gmail.com>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: ger.gmane.org 1447117973 31452 80.91.229.3 (10 Nov 2015 01:12:53 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Tue, 10 Nov 2015 01:12:53 +0000 (UTC)
To: help-gnu-emacs@gnu.org
Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Nov 10 02:12:43 2015
Return-path: <help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geh-help-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>)
	id 1ZvxUI-0005RO-3S
	for geh-help-gnu-emacs@m.gmane.org; Tue, 10 Nov 2015 02:12:42 +0100
Original-Received: from localhost ([::1]:56762 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org>)
	id 1ZvxUH-000605-H1
	for geh-help-gnu-emacs@m.gmane.org; Mon, 09 Nov 2015 20:12:41 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ZvxU4-0005zx-P8
	for help-gnu-emacs@gnu.org; Mon, 09 Nov 2015 20:12:29 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ZvxU1-0002dK-Gc
	for help-gnu-emacs@gnu.org; Mon, 09 Nov 2015 20:12:28 -0500
Original-Received: from plane.gmane.org ([80.91.229.3]:55894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ZvxU1-0002cY-Av
	for help-gnu-emacs@gnu.org; Mon, 09 Nov 2015 20:12:25 -0500
Original-Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geh-help-gnu-emacs@m.gmane.org>) id 1ZvxTx-00057Z-7F
	for help-gnu-emacs@gnu.org; Tue, 10 Nov 2015 02:12:21 +0100
Original-Received: from nl106-137-244.student.uu.se ([130.243.137.244])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <help-gnu-emacs@gnu.org>; Tue, 10 Nov 2015 02:12:21 +0100
Original-Received: from embe8573 by nl106-137-244.student.uu.se with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <help-gnu-emacs@gnu.org>; Tue, 10 Nov 2015 02:12:21 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: help-gnu-emacs@gnu.org
Original-Lines: 66
Original-X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: nl106-137-244.student.uu.se
Mail-Copies-To: never
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)
Cancel-Lock: sha1:ndYJzZWQEQo3P/ObkXAeLn7OHr0=
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 80.91.229.3
X-BeenThere: help-gnu-emacs@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Users list for the GNU Emacs text editor <help-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/help-gnu-emacs>,
	<mailto:help-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/help-gnu-emacs>
List-Post: <mailto:help-gnu-emacs@gnu.org>
List-Help: <mailto:help-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/help-gnu-emacs>,
	<mailto:help-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.help:108014
Archived-At: <http://permalink.gmane.org/gmane.emacs.help/108014>

jenia.ivlev@gmail.com (jenia.ivlev) writes:

> (defun insert-new-entry ()
>    (interactive)
>       (goto-char (point-max))
>       (define-key calendar-mode-map "\r" 'get-date)
>       (calendar))

That function first moves point to the end of the
buffer, than changes the key-map for the calendar
mode, then brings up the calendar.

1. Why is that called "insert-new-entry"?

2. Why move point? That happens *before* `calendar' is
   invoked. Remember your function can be called from
   anywhere in Emacs, i.e. from all modes and all
   buffers. Why move point in any and all of those?

3. If you want to change the key-map for a mode, don't
   do that in a defun. Just put this

       (require 'calendar)
       (define-key calendar-mode-map "\r" #'get-date)

    in an initiation file, i.e. most often ~/.emacs or
    some other file that is `load'ed from ~/.emacs.

Also, at least according to my Lisp-vision, there
shouldn't be indentation after the (interactive) line.
That is, the `goto-char' line should be align on the
same vertical level as the `interactive' line.

> (defun get-date ()
> (interactive)
>     (let* ((x (calendar-cursor-to-date))
>            (time (encode-time 0 0 0 (nth 1 x) (nth 0 x) (nth 2 x))))
>           (select-window (get-buffer-window "asti" t))
>           (insert (format-time-string "%Y-%m-%d" time))))

Even with the `encode-time' I still only get 1970s
dates! But if time works for you, still, check out
a previous post and the function I provided.

Some hints:

1. Be more pedantic with indentation!
   Use `indent-for-tab-command' (TAB) in the
   `emacs-lisp-mode' and let it be done for you.

2. Think of better names than `x'.

3. Instead of (nth 0 x), you can use `car'.

> P.S. This assumes you have an "asti" buffer opened
> (C-x 4 b asti).

Use `get-buffer-create' which will "[r]eturn the
buffer specified ... creating a new one if needed.
..." (from the help). get-buffer-create is what I used
in the function in my previous post, and that will
work regardless so you don't have to assume anything.

-- 
underground experts united
http://user.it.uu.se/~embe8573