From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https Date: Fri, 25 Dec 2015 22:03:35 +0100 Message-ID: <87egea1brs.fsf@gnus.org> References: <87bo5kixuj.wl%egh@e6h.org> <20130730141910.2167122AC01@mailgate.ucop.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451077495 10124 80.91.229.3 (25 Dec 2015 21:04:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Dec 2015 21:04:55 +0000 (UTC) Cc: 14983@debbugs.gnu.org, Andreas Schwab To: Erik Hetzner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 25 22:04:44 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aCZXX-0003Ku-V2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 22:04:44 +0100 Original-Received: from localhost ([::1]:36461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCZXX-0006I1-Cv for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 16:04:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCZWw-0005WN-08 for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aCZWs-0004XK-PQ for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:04:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCZWs-0004XG-Lp for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aCZWs-0006ko-Ac for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2015 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14983-submit@debbugs.gnu.org id=B14983.145107744125955 (code B ref 14983); Fri, 25 Dec 2015 21:04:02 +0000 Original-Received: (at 14983) by debbugs.gnu.org; 25 Dec 2015 21:04:01 +0000 Original-Received: from localhost ([127.0.0.1]:35530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZWq-0006kY-MP for submit@debbugs.gnu.org; Fri, 25 Dec 2015 16:04:00 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:49344) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZWp-0006kR-43 for 14983@debbugs.gnu.org; Fri, 25 Dec 2015 16:03:59 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCZWS-0004Pu-CM; Fri, 25 Dec 2015 22:03:36 +0100 In-Reply-To: <20130730141910.2167122AC01@mailgate.ucop.edu> (Erik Hetzner's message of "Tue, 30 Jul 2013 07:20:01 -0700") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aCZWS-0004Pu-CM MailScanner-NULL-Check: 1451682216.69812@8ZEP5SMHIb26nZumENgTIg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110450 Archived-At: Erik Hetzner writes: > This patch modifies url-https to support an optional retry-buffer > argument, making this better approach possible. > > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el > index 7f21a38..868b6ff 100644 > --- a/lisp/url/url-http.el > +++ b/lisp/url/url-http.el > @@ -895,8 +895,11 @@ should be shown to the user." > (let ((url-request-method url-http-method) > (url-request-extra-headers url-http-extra-headers) > (url-request-data url-http-data)) > - (url-http url-current-object url-callback-function > - url-callback-arguments (current-buffer))))) > + (if (string= "https" (url-type url-current-object)) > + (url-https url-current-object url-callback-function > + url-callback-arguments (current-buffer)) > + (url-http url-current-object url-callback-function > + url-callback-arguments (current-buffer)))))) > ((url-http-parse-headers) > (url-http-activate-callback)))))) > > @@ -1432,7 +1435,7 @@ p3p > ,@(remove '&rest (remove '&optional args)))))) > > ;;;###autoload (autoload 'url-https "url-http") > -(url-https-create-secure-wrapper nil (url callback cbargs)) > +(url-https-create-secure-wrapper nil (url callback cbargs &optional retry-buffer)) I think this looks sensible, but the patch it two years old, so I wonder whether there was a reason it wasn't applied back then? Or whether this was fixed a different way? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no