From: Lars Ingebrigtsen <larsi@gnus.org>
To: Erik Hetzner <erik.hetzner@ucop.edu>
Cc: 14983@debbugs.gnu.org, Andreas Schwab <schwab@suse.de>
Subject: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https
Date: Fri, 25 Dec 2015 22:03:35 +0100 [thread overview]
Message-ID: <87egea1brs.fsf@gnus.org> (raw)
In-Reply-To: <20130730141910.2167122AC01@mailgate.ucop.edu> (Erik Hetzner's message of "Tue, 30 Jul 2013 07:20:01 -0700")
Erik Hetzner <erik.hetzner@ucop.edu> writes:
> This patch modifies url-https to support an optional retry-buffer
> argument, making this better approach possible.
>
> diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
> index 7f21a38..868b6ff 100644
> --- a/lisp/url/url-http.el
> +++ b/lisp/url/url-http.el
> @@ -895,8 +895,11 @@ should be shown to the user."
> (let ((url-request-method url-http-method)
> (url-request-extra-headers url-http-extra-headers)
> (url-request-data url-http-data))
> - (url-http url-current-object url-callback-function
> - url-callback-arguments (current-buffer)))))
> + (if (string= "https" (url-type url-current-object))
> + (url-https url-current-object url-callback-function
> + url-callback-arguments (current-buffer))
> + (url-http url-current-object url-callback-function
> + url-callback-arguments (current-buffer))))))
> ((url-http-parse-headers)
> (url-http-activate-callback))))))
>
> @@ -1432,7 +1435,7 @@ p3p
> ,@(remove '&rest (remove '&optional args))))))
>
> ;;;###autoload (autoload 'url-https "url-http")
> -(url-https-create-secure-wrapper nil (url callback cbargs))
> +(url-https-create-secure-wrapper nil (url callback cbargs &optional retry-buffer))
I think this looks sensible, but the patch it two years old, so I wonder
whether there was a reason it wasn't applied back then? Or whether this
was fixed a different way?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2015-12-25 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 2:29 bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https Erik Hetzner
2013-07-30 8:50 ` Andreas Schwab
2013-07-30 14:01 ` Erik Hetzner
2013-07-30 14:20 ` Erik Hetzner
2015-12-25 21:03 ` Lars Ingebrigtsen [this message]
2019-05-20 18:56 ` Noam Postavsky
2019-09-24 7:58 ` Lars Ingebrigtsen
2013-07-30 14:20 ` Erik Hetzner
2019-06-17 2:58 ` Noam Postavsky
2019-06-20 1:20 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egea1brs.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=14983@debbugs.gnu.org \
--cc=erik.hetzner@ucop.edu \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.