From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mitchel Humpherys Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Sat, 27 Feb 2016 22:05:05 -0800 Message-ID: <87egbxid4e.fsf@gmail.com> References: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456639679 4632 80.91.229.3 (28 Feb 2016 06:07:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2016 06:07:59 +0000 (UTC) Cc: Kristoffer Gronlund To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 28 07:07:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZuWL-0005ZP-NQ for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 07:07:57 +0100 Original-Received: from localhost ([::1]:57639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZuWK-0006zM-VY for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 01:07:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZuW8-0006yk-8V for emacs-devel@gnu.org; Sun, 28 Feb 2016 01:07:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZuW7-0001vj-EZ for emacs-devel@gnu.org; Sun, 28 Feb 2016 01:07:44 -0500 Original-Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:34505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZuW7-0001vf-7F for emacs-devel@gnu.org; Sun, 28 Feb 2016 01:07:43 -0500 Original-Received: by mail-pf0-x229.google.com with SMTP id x65so75208446pfb.1 for ; Sat, 27 Feb 2016 22:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Ut4uwsyP0EIZq8r7GTfaw+TQE0T45V9nfC+1gVjha0Q=; b=Pe98dpkBLxEOX+3Kbkzpv7rq7OFQcDAEryJNT6lCOwqihNHISYIcWC4YPIGHgGa70Q x8Wr5T62NqGn3ZuD0Yk7sdObPt7sZji3wdw22CREZBYqsbORIrnFGhMNS7fnGfR2ZSBf 8WwXuWi8cVNx48gunaPGH5Wv6YRgtS0g1nWTYjW0AtBFZVZLQwYlTSJrA4+RE/QRz7Eu ivKpagZMxWV1ORmVZr86E+7C0rx5Q14l0O/xvB5HZZWLC5Ddt3sTpG2aIXxhYCn1CHxi kzC6BlQH1DitvvUOVeHsag0cUq/oUsK9rgT+dNssddljL7vHbV3dLi/vGKjXaNLVGesw g2/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Ut4uwsyP0EIZq8r7GTfaw+TQE0T45V9nfC+1gVjha0Q=; b=Bv1nehQhN+7ZMquO80H2rBWdvyUMId1/QYeDkuXnaKqj5yZm2+lrCQtc8k2lvB41pO YeV2FppcezK76cmJJKI6homsMVgUwrK/QreTigsLWD5H6at9Dqy2SDKyYdxWp8OIHuB6 bqN4BIByFhVTYAIY6oe1GP5rUloma8BcgN+3ND43dy8PjOouTj8jkae3fSdpG+TlWd0m os9ji7TeDN6GAz93p3JM29FCE4ZLq5VBJ8OZmDUZ8Remmh+gEFI6+1HbJjqpmtHnFIiT GvRUWM4LbYkaUuYbJskfVPsaAxInBscUKKuDhSwdniuzVzoovsL7BWNte+zpSBjQ3www GGzQ== X-Gm-Message-State: AD7BkJKBP42fPnEiTH4T4qO/KCRWsbnjhMGf7uuSZhVGIrSuKArFv6oyRVSItbLAblYX7A== X-Received: by 10.98.9.219 with SMTP id 88mr13989446pfj.0.1456639662067; Sat, 27 Feb 2016 22:07:42 -0800 (PST) Original-Received: from space ([2600:8801:f900:f34:d59b:8fe9:9a45:b223]) by smtp.gmail.com with ESMTPSA id r6sm4813142pfi.9.2016.02.27.22.07.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Feb 2016 22:07:40 -0800 (PST) In-Reply-To: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> (Mitchel Humpherys's message of "Mon, 22 Feb 2016 17:04:31 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200744 Archived-At: On Mon, Feb 22 2016 at 05:04:31 PM, Mitchel Humpherys wrote: > Setting a foreground color on the `region' face is slightly annoying. > This is subjective, of course, but the consensus among other themes and > around the web is to *not* set a foreground color on the region face. Any objections to this? I should have mentioned that the reason it's slightly annoying is because setting a foreground color hides existing syntax highlighting within the region text. -- Mitch