From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolaus Rath Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Tue, 08 Mar 2016 08:39:18 -0800 Message-ID: <87egbk6i15.fsf@thinkpad.rath.org> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> <834mchtz8q.fsf@gnu.org> <878u1ta97x.fsf@wanadoo.es> <83mvq9rmh6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1457455240 29971 80.91.229.3 (8 Mar 2016 16:40:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 16:40:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 17:40:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adKfc-0005oT-FO for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 17:39:40 +0100 Original-Received: from localhost ([::1]:35804 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKfW-0001Nz-S0 for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 11:39:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKfN-0001DF-PV for emacs-devel@gnu.org; Tue, 08 Mar 2016 11:39:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKfK-0003tE-Gm for emacs-devel@gnu.org; Tue, 08 Mar 2016 11:39:25 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKfK-0003t5-DG for emacs-devel@gnu.org; Tue, 08 Mar 2016 11:39:22 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4012020C5B for ; Tue, 8 Mar 2016 11:39:20 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Tue, 08 Mar 2016 11:39:20 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=kIjT36s2tQEVTcL imAnlaVpsllw=; b=t3NZlTJ89B1bv7I17uwUmXHnFVRy+1yI4m77/brd/EeHqAl Xbjjl65YttkyljqMx0CaJjRgJMzMGns4KzRm0Z4y2+H07khGVd2m7M+APyAlvP3b EC0DVWoeYh9homQ5jJyNEzxhngnqGddn8xE5cI0OKHLfwsoIBEUJQuFuHJx8= X-Sasl-enc: gvu/t8tEg+kg8Uw+JhPHkgep4ciBw6vzsZW7VTLtr37E 1457455159 Original-Received: from ebox.rath.org (ebox.rath.org [45.79.69.51]) by mail.messagingengine.com (Postfix) with ESMTPA id EAD4C680110 for ; Tue, 8 Mar 2016 11:39:19 -0500 (EST) Original-Received: from thinkpad.rath.org (thinkpad [192.168.12.2]) by ebox.rath.org (Postfix) with ESMTPS id 2D25B20D959 for ; Tue, 8 Mar 2016 16:39:19 +0000 (UTC) Original-Received: by thinkpad.rath.org (Postfix, from userid 1000) id DF6ABC01BD; Tue, 8 Mar 2016 08:39:18 -0800 (PST) Mail-Copies-To: never Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <83mvq9rmh6.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Mar 2016 17:57:41 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201172 Archived-At: On Mar 08 2016, Eli Zaretskii wrote: >> From: =C3=93scar Fuentes >> Date: Tue, 08 Mar 2016 05:23:46 +0100 >>=20 >> >> Introduce code reviews. Don't give commit access to the "golden" >> >> branches to everyone, just to a few top contributors and reviewers. >> > >> > We don't have manpower for that. >>=20 >> I find perplexing that we have manpower for reviewing ChangeLogs but not >> for reviewing commit logs *instead*. > > I'm surprised that you find it perplexing. > > Log messages are much shorter than code diffs, and much simpler to > read and understand. =C3=93scar was talking about reviewing the *commit message* instead of the changelog, not about reviewing the entire commit (including the diff) instead. Best, -Nikolaus --=20 GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F =C2=BBTime flies like an arrow, fruit flies like a Banana.=C2= =AB