From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match Date: Sat, 02 Apr 2016 21:37:51 +0200 Message-ID: <87eganpzsg.fsf@gmx.de> References: <8337r4rme5.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459625967 15006 80.91.229.3 (2 Apr 2016 19:39:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2016 19:39:27 +0000 (UTC) Cc: Jerry Asher , 23186@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 02 21:39:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amRO1-00029o-SV for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 21:39:10 +0200 Original-Received: from localhost ([::1]:50736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRO1-0003fY-6q for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 15:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRNx-0003dU-J9 for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 15:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amRNu-0000YQ-9y for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 15:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amRNu-0000YJ-6L for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amRNt-0007oR-Vq for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 15:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Apr 2016 19:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23186-submit@debbugs.gnu.org id=B23186.145962588329964 (code B ref 23186); Sat, 02 Apr 2016 19:39:01 +0000 Original-Received: (at 23186) by debbugs.gnu.org; 2 Apr 2016 19:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:49127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amRMw-0007nE-Vd for submit@debbugs.gnu.org; Sat, 02 Apr 2016 15:38:03 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:64198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amRMv-0007mj-D2 for 23186@debbugs.gnu.org; Sat, 02 Apr 2016 15:38:01 -0400 Original-Received: from detlef.gmx.de ([93.209.89.206]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MLi1v-1anGJW0tsJ-000q0D; Sat, 02 Apr 2016 21:37:53 +0200 In-Reply-To: <8337r4rme5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Apr 2016 19:44:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:r8IGnT1E+7zOJEEfO/VCaOPwTqyc31bxcAaYBukPXHHWa5Hv6hy hUwx5smRHgut4xRCy2f2FUiJMdg8yInQ2W1S8BPGBfRF+5LespE9b7/0X7JLII2jnrSpWJj shh+IRTMLVbk9ZgSSv4IPj/x6+Bget7L30Df2TwgP7R2kBqgzkC1wqMjqu7XHNHpl3eTU9e yBTstaoNSPV8/hAPfL8Jg== X-UI-Out-Filterresults: notjunk:1;V01:K0:/aWkx7GaNd0=:Wra5qTT5q3f/ae3faQAWNp ZkwqO6sIwBNkiaqP9ehymhURIzdrt/yaYoSjno7+b8lA4GDyjJ6Z8JpJBO8K3ZSqGHcyjLtDG wu8YeNQPqpdgMD4Av4+grJFb+xb5vk/rk01N/5+HaQCCVkjfmn1yEgDbbEdX25wgHKju/QiBn NUNgnDosDZehxL4rAc5vEQKlp2nM9Dvfkgi9uzcyaAOLk43L6P3qudx/+QUFq0c4tGj835zeK 3WGOj0exXfp88fHOqpw+63qDKanZi01mdNsvYt/V7jz/UofqPEn0qtnHPma1YYIyeQQf2+dhX 5PuDlF4aWql9UhKs4RyugU1QfwFSVXSEMmeOBMaJxXQjf9p+FZyGQFwmGkHYEoxUI4RpnZ3Fx ycUrTE9vRHZwAMW36M3z5HZX9MR2TXddJinnfFuWqsyXFu7kSxvNVbWolMCeNN9bv5CobQoKK zfWDyNahbVRUsj2pPa1Yg61g+GBYNfJtl5uto/OwSNXx7MsESAKjamf/ukUgfgs0SnEdV2tA4 TT7MzC775os0Cx1uiuYdE8g3s/AwG1FFND8gPOqInfz21sH1BRAgx+V4SS19qUJyyEQ4lHE5L P3UKuyhhyHTPKUvl8405Udkqtv5MSB3PDMUPjL/dh1FLAdu+uT49NQkSXrRyUuTB7ItAInGxF kWT37+p75gn5sIEQJOKtmggS/BMXiq4acPgzazLA4u5W5dNOEXAjVKkYI2Vt0FuPRuJMFVbkH Wtvg7wv7nQIVJ3/3y0VCJXtVygXCpTP36eMXRLbnYjmLb6glgLZUIUSlfTwzIFpecnp+/FTh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115887 Archived-At: Eli Zaretskii writes: >> Regardless, I would say the assumption that COMSPEC is always set >> and so therefore if it fails it is okay to >> assign nil to tramp-encoding-shell knowing that later on it will be >> in a string-match is problematic in and of >> itself. > > Tramp is designed to work with Emacs as released by the Emacs > development team. That Emacs doesn't have this problem. I think it > would be unreasonable for anyone to expect the Tramp maintainers to > cater to arbitrary changes in the Emacs code or in how it is > configured on Windows, let alone if you poke some addresses in the PE > headers of the produced binary. The Tramp maintainers could check, whether COMSPEC is set, and raise a verbose warning in case it isn't. Refusing further work. Shall I commit this to the emacs-25 branch, or to master? Best regards, Michael.