From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tao Fang Newsgroups: gmane.emacs.bugs Subject: bug#23290: 25.1.50; eww: =?UTF-8?Q?Symbol=E2=80=99s?= value as variable is void: url-http-response-status Date: Sun, 17 Apr 2016 01:19:01 +0800 Message-ID: <87ega5mpyy.fsf@gmail.com> References: <878u0gxb3j.fsf@web.de> <87bn5azt4b.fsf@gmail.com> <87zistprwv.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1460827226 22398 80.91.229.3 (16 Apr 2016 17:20:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Apr 2016 17:20:26 +0000 (UTC) Cc: larsi@gnus.org, 23290@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 16 19:20:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arTtG-0006PZ-CQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2016 19:20:14 +0200 Original-Received: from localhost ([::1]:58773 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arTtC-0003pM-EQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Apr 2016 13:20:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arTt7-0003kk-VR for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arTt4-0000OS-Or for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arTt4-0000OO-LP for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1arTt4-0000XS-Gn for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tao Fang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Apr 2016 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.14608271792033 (code B ref -1); Sat, 16 Apr 2016 17:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Apr 2016 17:19:39 +0000 Original-Received: from localhost ([127.0.0.1]:37594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arTsh-0000Wi-8V for submit@debbugs.gnu.org; Sat, 16 Apr 2016 13:19:39 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arTsg-0000WW-5C for submit@debbugs.gnu.org; Sat, 16 Apr 2016 13:19:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arTsa-0000Mi-5W for submit@debbugs.gnu.org; Sat, 16 Apr 2016 13:19:33 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arTsa-0000Me-2a for submit@debbugs.gnu.org; Sat, 16 Apr 2016 13:19:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arTsZ-0001Wo-3i for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:19:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arTsV-0000MS-UG for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:19:31 -0400 Original-Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:34036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arTsV-0000MO-Pa for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2016 13:19:27 -0400 Original-Received: by mail-qg0-x241.google.com with SMTP id m8so1354038qgd.1 for ; Sat, 16 Apr 2016 10:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:user-agent:date:in-reply-to :message-id:mime-version; bh=d5s4RjsKEkg3tVFL/wjyvjhC5w6fICBMT+8QHq0PWE8=; b=rgWf9gb7ha9aZ27YHV5rEfJQ4+IaWRpFlpgvSmGwdMpAy9b46RchT8eT941zUIs+ZA SCbxo54/AoAoCrizlUMB6Evtk+yMoQ7OhSqiH77MNCT3XDpmnt99R17pxCb/Fu8D96Jd c31N2MDcmqNQ6S2rEqlT5jmSalbOZe8B9D8e0c3N+2WoUBcIGe9bYQSdQntCylP3GM+S LYNe6BZedfEVPpHTq0n7Q4Km+FEgETXVDXYeOQ1syEa6zqzswfSsX5tkRHC99NEfGFlV zPq4c+ZX4B+3OZAOukOUcR2nFORW6d8r+n3e15FWPTwNTcC+EZf720ly4W8nzKk01WlO cGsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:user-agent:date :in-reply-to:message-id:mime-version; bh=d5s4RjsKEkg3tVFL/wjyvjhC5w6fICBMT+8QHq0PWE8=; b=XgdzSEf0nHsmN/F84Jh64upOP5uudDLtjHpJTeTOengzg2u7ZWgZNZbw7CEq/Yr6PW z23TeuDx8CCaYQP82uST4TnI+Hdbb8WaiWOgeS7aYvzAU1wgProqdxb5Sl9jHvDcSwPD y6dEy3O2+rVGA7/eVIazLUeot/PbHTzoN4iyAMyR1HQH6cDu71YKjEIpp21O8v3HtYc+ dRJdkzX4lcG+bEZbfeqqMzZ2NweYeiy58PbDInDI0YbxPCZq7gcAuka1EEJptQIoLTSV xWyES0sNqdFH/JyEzdJeZkSlN9GVTGZiSg2iIBeHbCfoUWmKo4W2S1RwPJprnvtogbsd 5LjQ== X-Gm-Message-State: AOPr4FVuNds8bu7238DLpWMtcOe0o9MSNDZwxLqhFLnpMufDh4rQ1TKfy6DNtZVrBFRa1w== X-Received: by 10.140.20.14 with SMTP id 14mr32661120qgi.66.1460827167499; Sat, 16 Apr 2016 10:19:27 -0700 (PDT) Original-Received: from StormPC.yourcompany.com (ec2-52-3-137-119.compute-1.amazonaws.com. [52.3.137.119]) by smtp.gmail.com with ESMTPSA id j103sm15664747qge.0.2016.04.16.10.19.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Apr 2016 10:19:26 -0700 (PDT) User-Agent: Emacs/Gnus In-Reply-To: <87zistprwv.fsf@web.de> (Michael Heerdegen's message of "Sat, 16 Apr 2016 16:08:48 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116534 Archived-At: --=-=-= Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: quoted-printable Hi, Michael After some digging, I found a code bug in commit 3c623c26ae7d695746e05d8a2e16a67a6256b024 introduced by me and maybe relavant to your report. lisp/url/url-http.el: 1319 (defun url-https-proxy-after-change-function (st nd length) ...... 1327 (url-http-parse-response) 1328 (cond ...... 1360 (t 1361 (url-http-activate-callback) 1362 (message "error response: %d" url-http-response-status)))))) ...... When using url-http in eww and the above "cond" last clause succeed (i.e. at first connecting to proxy response not HTTP 200), "url-http-activa= te-callback" will call function "eww-render" which calls (kill-buffer), so the code next line visit symbol url-http-response-status will cause the error: "Symbol=A1=AFs value as variable is void: url-http-response-status". This can be fixed simplely transpose that two code lines: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-fix-void-variable-url-http-response-status.patch >From 323cf52e870f6f6a5965d22891ea27f87b971011 Mon Sep 17 00:00:00 2001 From: Tao Fang Date: Sun, 17 Apr 2016 00:21:09 +0800 Subject: [PATCH] fix: (void-variable url-http-response-status) --- lisp/url/url-http.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 1fe9ac2..5cf641d 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -1358,8 +1358,8 @@ The return value of this function is the retrieval buffer." (error "error: %s" e))) (error "error: gnutls support needed!"))) (t - (url-http-activate-callback) - (message "error response: %d" url-http-response-status)))))) + (message "error response: %d" url-http-response-status) + (url-http-activate-callback)))))) (defun url-http-async-sentinel (proc why) ;; We are performing an asynchronous connection, and a status change -- 2.8.1 --=-=-= Content-Type: text/plain Can you help to apply the patch and test on that in your environment? And I'm not sure about this, because only using https proxy will enter this function(if I do it right?), I still need to find out about it. Thanks for your help! -- Emacs/Gnus --=-=-=--