Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

[Stefan Monnier]

>      (kill-local-variable 'eldoc-message-commands)
>      (remove-hook 'post-command-hook 'eldoc-schedule-timer t)
> -    (remove-hook 'pre-command-hook 'eldoc-pre-command-refresh-echo-area t))))
> +    (remove-hook 'pre-command-hook 'eldoc-pre-command-refresh-echo-area t)
> +    (when eldoc-timer
> +      (cancel-timer eldoc-timer)
> +      (setq eldoc-timer nil)))))
 
Hmm... IIUC the timer is global (i.e. shared by all buffers), whereas
the above code is run when disabling eldoc-mode in one
particular buffer.  So it doesn't look right.


        Stefan

Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

[Lars Ingebrigtsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>      (kill-local-variable 'eldoc-message-commands)
>>      (remove-hook 'post-command-hook 'eldoc-schedule-timer t)
>> -    (remove-hook 'pre-command-hook 'eldoc-pre-command-refresh-echo-area t))))
>> +    (remove-hook 'pre-command-hook 'eldoc-pre-command-refresh-echo-area t)
>> +    (when eldoc-timer
>> +      (cancel-timer eldoc-timer)
>> +      (setq eldoc-timer nil)))))
>
> Hmm... IIUC the timer is global (i.e. shared by all buffers), whereas
> the above code is run when disabling eldoc-mode in one
> particular buffer.  So it doesn't look right.

As far as I could tell, the post-command-hook in the other buffers
should restart the timer if it isn't running.  So if you have eldoc mode
running in another buffer, it should start again once you do anything in
them?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

[Michael Heerdegen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> >      (kill-local-variable 'eldoc-message-commands)
> >      (remove-hook 'post-command-hook 'eldoc-schedule-timer t)
> > - (remove-hook 'pre-command-hook
> > 'eldoc-pre-command-refresh-echo-area t))))
> > + (remove-hook 'pre-command-hook
> > 'eldoc-pre-command-refresh-echo-area t)
> > +    (when eldoc-timer
> > +      (cancel-timer eldoc-timer)
> > +      (setq eldoc-timer nil)))))
>  
> Hmm... IIUC the timer is global (i.e. shared by all buffers), whereas
> the above code is run when disabling eldoc-mode in one particular
> buffer.  So it doesn't look right.

Yes.

And Lars, please also see bug#19853.  When Dmitry will fix this, I think
this issue here will be fixed as side effect.


Michael.

Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

[Stefan Monnier]

> As far as I could tell, the post-command-hook in the other buffers
> should restart the timer if it isn't running.  So if you have eldoc mode
> running in another buffer, it should start again once you do anything in
> them?

Oh, looks like you're right.  Sorry,


        Stefan