From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21252: 25.0.50; `describe-variable': use current buffer, not minibuffer, in `completing-read' PREDICATE Date: Sun, 01 May 2016 00:09:18 +0200 Message-ID: <87eg9m92b5.fsf@gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462054243 4147 80.91.229.3 (30 Apr 2016 22:10:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Apr 2016 22:10:43 +0000 (UTC) Cc: 21252@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 01 00:10:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awd5r-00044W-Kh for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 00:10:31 +0200 Original-Received: from localhost ([::1]:59904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awd5n-0004BW-Cl for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 18:10:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awd5d-0003wZ-RT for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 18:10:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awd5S-0006Qp-20 for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 18:10:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awd5R-0006P5-VZ for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 18:10:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awd5O-0006bv-GB for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 18:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2016 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21252 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21252-submit@debbugs.gnu.org id=B21252.146205416225340 (code B ref 21252); Sat, 30 Apr 2016 22:10:02 +0000 Original-Received: (at 21252) by debbugs.gnu.org; 30 Apr 2016 22:09:22 +0000 Original-Received: from localhost ([127.0.0.1]:58653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awd4k-0006ae-Dz for submit@debbugs.gnu.org; Sat, 30 Apr 2016 18:09:22 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:60961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awd4j-0006aX-Ar for 21252@debbugs.gnu.org; Sat, 30 Apr 2016 18:09:21 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awd4g-0007XR-P8; Sun, 01 May 2016 00:09:20 +0200 In-Reply-To: (Drew Adams's message of "Thu, 13 Aug 2015 08:44:24 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117458 Archived-At: Drew Adams writes: > This bug is at least as old as Emacs 20! Never noticed it before. > > 1. emacs -Q > 2. Type this in *scratch* and evaluate it using `C-x C-e': > > (set (make-local-variable 'toto) 42) > > 3. C-h v tot TAB > > There is no completion for variable `toto'. > > The reason is that the PREDICATE arg passed to `completing-read' gets > evaluated with the minibuffer as the current buffer, and `toto' is not > bound in the minibuffer. > > The predicate should use `with-current-buffer' to make the originally > current buffer current for the test. Makes sense. I applied your changes, slightly changed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no