From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#13670: 24.3.50; `autoload-generate-file-autoloads' off-by-one bug Date: Sun, 01 May 2016 17:34:09 +0200 Message-ID: <87eg9l3i8e.fsf@web.de> References: <8E0945F19B9F4E37BA18A7A2232F6411@us.oracle.com> <87pot92wqw.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462116945 6603 80.91.229.3 (1 May 2016 15:35:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 May 2016 15:35:45 +0000 (UTC) Cc: 13670@debbugs.gnu.org, Lars Ingebrigtsen To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 01 17:35:34 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awtPB-0005RY-Fz for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 17:35:33 +0200 Original-Received: from localhost ([::1]:33461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awtP4-0000lE-FT for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 11:35:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awtOv-0000b2-5o for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 11:35:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awtOj-0005zS-F0 for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 11:35:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awtOj-0005xs-Bu for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 11:35:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awtOf-00067Y-W4 for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2016 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13670-submit@debbugs.gnu.org id=B13670.146211686623484 (code B ref 13670); Sun, 01 May 2016 15:35:01 +0000 Original-Received: (at 13670) by debbugs.gnu.org; 1 May 2016 15:34:26 +0000 Original-Received: from localhost ([127.0.0.1]:60814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awtO6-00066i-Kt for submit@debbugs.gnu.org; Sun, 01 May 2016 11:34:26 -0400 Original-Received: from mout.web.de ([212.227.15.4]:58095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awtO4-00066U-Pe for 13670@debbugs.gnu.org; Sun, 01 May 2016 11:34:25 -0400 Original-Received: from drachen.dragon ([94.217.122.112]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0MI5yY-1axSPs4B4A-003scm; Sun, 01 May 2016 17:34:11 +0200 In-Reply-To: (Drew Adams's message of "Fri, 29 Apr 2016 09:11:31 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-Provags-ID: V03:K0:hkLl4o2SLvW0zhHu5B9uWNbfj005RymyukJn50WbRrFUmfjLv5k 2uLtZEK/V9t1VNl+G4Bpa+vc09Oi/9+NnhrK9BPZjdTUH/NiTaw35N6z2EMqAMqiSbitgDD L4P4SbiPg7/xJGrwwTwjhTCPaKUJWWWOHFTsc7sabreG5lQAPZiFIAvMAS/kmn7mzhJhUhv X9aRBuSMT74DFxajDljfQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:a+BQtVOQ9hQ=:lSeftzWwgiL5lKso71nPPP 1hAJ1RwkpgPsFjGLy90ety7lNcZT5gNNT1xxbnSYC2AGdITOEzWuo9ebv1ZtAn0V6NZSpx8mG 2XQIW/SwLqPeErsGaUl3AfM6B5XO95WwDJMnPJuagcj3XWhZY+Bp/1vkM08PvfqzeqSTaYBS7 dK4sDl0Ql0H8/GDu+UQfJaNCKaXainULIEmN0PMYegwyJsIkKJJpSJ27Ro70iNXPhmjZDLPTr 0wzfMd1IjieA9yrYi3PrnEc1vPby7cWoHvnQoSBbKPQN7R50wzrLBZDtzDMqNhBEQgTCRF/68 jhn0DFKn8Iwn4d89O23D2NmvepT8Qje3m9HI0osyVdHCwlbyOMsyD3Sig2PexUbmJmLps7FKr 4FBPrhXmCtmv01Cy/Fa4Nvh0PxuQWK6ZRySKklma+MMasbRYHCx2MxJKmREgdxUfKFOH9eaBE etJYSMUZYZcrbhnFWVcp8SK6TJrOSeN2/UNWAYN3KWpfXFhbkI6+/ekV2NdDlA79nuOfOtg9G RTzEzR+pOreJOBo7L2tqgO4fTqpKZ3EvwQ7hdhmggAM4KBUFBShxoI2qzWZRvzUC4TJDY7xxD SLJjeWwI5heTuVxQmORRQPPkVxApoIZkhO2cEIvt+dRfM6bjEudQ2OTWokYRnB24BA7hJPKSA 5Hm+NzKx71gZCsFJhqMX0IwVGzDGPoVh4H5/Ka/puDwFLZHzJglKZ77WSXHnMt42dU2eObHgc IwGcXJMHw6pJlNq+TYO7NwdqRgPw/G5bGRbx3em9uJAVp5dRRX9TCYR/xAE3VG9pr7xUyzHu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117510 Archived-At: Drew Adams writes: > > If we make this change, then autoloads that want to have a single space > > at the start of the string (and use this syntax to do that) would then > > not have that space? > > No. See the bug report. Only the first SPC should be used > as a separator. If you want an initial SPC char included > then you use SPC SPC. > > > Have you examined the sources to see whether that's potentially a > > problem? > > No. Do you see a problem with it? Do you disagree that this > is a bug, regardless of whether you doubt the proposed solution? The emacs-25 version of `autoload-generate-file-autoloads' does not contain a call to `char-after', so I think it has been rewritten in the meantime. Moreover, if I let Emacs generate file autoloads for a file with this content: #+begin_src emacs-lisp ;;;###autoload (autoload 'icicle-mode "icicles" ;;;###autoload"Icicle mode: Toggle minibuffer input completion and cycling. ;;;###autoloadNon-nil prefix ARG turns mode on if ARG > 0, else off. ;;;###autoloadIt is a global minor mode. It binds minibuffer keys." ;;;###autoloadt nil) #+end_src (update-file-autoloads "/home/micha/today/test.el" nil "/home/micha/today/test-auto.el") the result looks like this: #+begin_src emacs-lisp (autoload 'icicle-mode "icicles" "Icicle mode: Toggle minibuffer input completion and cycling. Non-nil prefix ARG turns mode on if ARG > 0, else off. It is a global minor mode. It binds minibuffer keys." nil) #+end_src So this generates a sane docstring. Is this acceptable? Michael.